Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issue 575253002: Clean up unused param in RegistryOverrideManager (Closed)

Created:
6 years, 3 months ago by gab
Modified:
6 years, 3 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, vandebo (ex-Chrome), Lei Zhang, grt+watch_chromium.org, wfh+watch_chromium.org, tommycli, Greg Billock, caitkp+watch_chromium.org, chromium-apps-reviews_chromium.org, erikwright+watch_chromium.org, grt (UTC plus 2)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Clean up unused param in RegistryOverrideManager This param has been unused since http://crrev.com/234367 and makes the method confusing. BUG=314800 Committed: https://crrev.com/6f7c83b276431b5473bd064e4eb315d60e17744f Cr-Commit-Position: refs/heads/master@{#295400}

Patch Set 1 #

Patch Set 2 : fix more callers #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -49 lines) Patch
M base/test/test_reg_util_win.h View 1 chunk +4 lines, -5 lines 0 comments Download
M base/test/test_reg_util_win.cc View 1 chunk +1 line, -3 lines 0 comments Download
M base/test/test_reg_util_win_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_elf_init_unittest_win.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/extensions/api/messaging/native_messaging_test_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media_galleries/media_galleries_test_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/environment_data_collection_win_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/gcapi/gcapi_last_run_test.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/installer/gcapi/gcapi_test_registry_overrider.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/installer/setup/setup_util_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/installer/util/google_update_settings_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/installer/util/install_util_unittest.cc View 10 chunks +10 lines, -10 lines 0 comments Download
M chrome/installer/util/installer_state_unittest.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/installer/util/product_state_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/product_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/work_item_list_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome_elf/blacklist/test/blacklist_test.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome_elf/chrome_elf_util_unittest.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M rlz/test/rlz_test_helpers.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
gab
@Pawel for base/test main change. @thakis for rubberstamp on side-effects in chrome/ CC tommicli/grt as ...
6 years, 3 months ago (2014-09-17 23:05:51 UTC) #2
gab
+robertshield for installer/chrome_elf (and thakis again for rlz/)
6 years, 3 months ago (2014-09-17 23:07:29 UTC) #4
Nico
lgtm Sorry, didn't see this the first time round: https://code.google.com/p/chromium/issues/detail?id=415395
6 years, 3 months ago (2014-09-18 00:29:19 UTC) #5
Nico
(nit: s/cleanup/clean up/ in the cl description. The former is a noun, the latter is ...
6 years, 3 months ago (2014-09-18 01:25:54 UTC) #6
robertshield
lgtm
6 years, 3 months ago (2014-09-18 01:38:58 UTC) #7
gab
On 2014/09/18 01:38:58, robertshield wrote: > lgtm Thanks, TBR Pawel since this is such a ...
6 years, 3 months ago (2014-09-18 01:48:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/575253002/20001
6 years, 3 months ago (2014-09-18 01:48:41 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001) as f20327370bcbdd124856410b75bdebda4af4e4ad
6 years, 3 months ago (2014-09-18 02:38:00 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-18 02:38:54 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6f7c83b276431b5473bd064e4eb315d60e17744f
Cr-Commit-Position: refs/heads/master@{#295400}

Powered by Google App Engine
This is Rietveld 408576698