Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(943)

Unified Diff: util/mach/exception_ports_test.cc

Issue 575243002: Use ExcServerSuccessfulReturnValue() in one spot that was missed (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: util/mach/exception_ports_test.cc
diff --git a/util/mach/exception_ports_test.cc b/util/mach/exception_ports_test.cc
index 7da1d56de23f36c7e0abc3cc4a807cc752dcfa1e..4164ca58d092fae3b655cc340327c7fddd4b1177 100644
--- a/util/mach/exception_ports_test.cc
+++ b/util/mach/exception_ports_test.cc
@@ -198,17 +198,7 @@ class TestExceptionPorts : public UniversalMachExcServer,
SetExpectedChildTermination(kTerminationSignal, signal);
}
- // Even for an EXC_CRASH handler, returning KERN_SUCCESS with a
- // state-carrying reply will cause the kernel to try to set a new thread
- // state, leading to a perceptible waste of time. Returning
- // MACH_RCV_PORT_DIED is the only way to suppress this behavior while also
- // preventing the kernel from looking for another (host-level) EXC_CRASH
- // handler. See 10.9.4 xnu-2422.110.17/osfmk/kern/exception.c
- // exception_triage().
- exception_behavior_t basic_behavior = behavior & ~MACH_EXCEPTION_CODES;
- bool has_state = basic_behavior == EXCEPTION_STATE ||
- basic_behavior == EXCEPTION_STATE_IDENTITY;
- return has_state ? MACH_RCV_PORT_DIED : KERN_SUCCESS;
+ return ExcServerSuccessfulReturnValue(behavior, false);
}
private:
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698