Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 575213002: Update chrome://welcome resources with Material/M37 look and feel (Closed)

Created:
6 years, 3 months ago by mmccoy
Modified:
6 years, 3 months ago
CC:
chromium-reviews, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Update chrome://welcome resources with Material/M37 look and feel BUG=399456 Committed: https://crrev.com/5ce3577e3fb5e043dc13229c06423823c60f7abc Cr-Commit-Position: refs/heads/master@{#296186}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Linting and addressing CL comments #

Patch Set 3 : Don't use remote resource url for font-face #

Total comments: 2

Patch Set 4 : CSS lint fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -16 lines) Patch
M chrome/browser/resources/about_welcome_android/about_welcome_android.css View 1 2 3 3 chunks +15 lines, -16 lines 0 comments Download
M chrome/browser/resources/about_welcome_android/images/holo_logo_150.png View Binary file 0 comments Download
M chrome/browser/resources/about_welcome_android/images/holo_logo_200.png View Binary file 0 comments Download

Messages

Total messages: 24 (8 generated)
mmccoy
Hi Ted, In relation to crbug/399456, updates the clank welcome splash page.
6 years, 3 months ago (2014-09-18 14:42:38 UTC) #2
Ted C
lgtm
6 years, 3 months ago (2014-09-18 21:01:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/575213002/1
6 years, 3 months ago (2014-09-19 15:03:00 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/12131)
6 years, 3 months ago (2014-09-19 15:13:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/575213002/1
6 years, 3 months ago (2014-09-19 21:20:33 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/575213002/1
6 years, 3 months ago (2014-09-19 21:20:35 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/12277)
6 years, 3 months ago (2014-09-19 21:38:45 UTC) #14
Dan Beam
https://codereview.chromium.org/575213002/diff/1/chrome/browser/resources/about_welcome_android/about_welcome_android.css File chrome/browser/resources/about_welcome_android/about_welcome_android.css (right): https://codereview.chromium.org/575213002/diff/1/chrome/browser/resources/about_welcome_android/about_welcome_android.css#newcode5 chrome/browser/resources/about_welcome_android/about_welcome_android.css:5: @import url('//fonts.googleapis.com/css?family=RobotoDraft:regular,bold,italic,thin,light,bolditalic,black,medium'); why is this a remote URL? https://codereview.chromium.org/575213002/diff/1/chrome/browser/resources/about_welcome_android/about_welcome_android.css#newcode46 ...
6 years, 3 months ago (2014-09-19 21:43:40 UTC) #15
mmccoy
https://codereview.chromium.org/575213002/diff/1/chrome/browser/resources/about_welcome_android/about_welcome_android.css File chrome/browser/resources/about_welcome_android/about_welcome_android.css (right): https://codereview.chromium.org/575213002/diff/1/chrome/browser/resources/about_welcome_android/about_welcome_android.css#newcode5 chrome/browser/resources/about_welcome_android/about_welcome_android.css:5: @import url('//fonts.googleapis.com/css?family=RobotoDraft:regular,bold,italic,thin,light,bolditalic,black,medium'); On 2014/09/19 21:43:39, Dan Beam wrote: > ...
6 years, 3 months ago (2014-09-21 13:32:34 UTC) #16
mmccoy
On 2014/09/21 13:32:34, mmccoy wrote: > https://codereview.chromium.org/575213002/diff/1/chrome/browser/resources/about_welcome_android/about_welcome_android.css > File chrome/browser/resources/about_welcome_android/about_welcome_android.css > (right): > > https://codereview.chromium.org/575213002/diff/1/chrome/browser/resources/about_welcome_android/about_welcome_android.css#newcode5 ...
6 years, 3 months ago (2014-09-22 13:02:55 UTC) #17
mmccoy
6 years, 3 months ago (2014-09-22 13:03:00 UTC) #18
Dan Beam
lgtm https://codereview.chromium.org/575213002/diff/40001/chrome/browser/resources/about_welcome_android/about_welcome_android.css File chrome/browser/resources/about_welcome_android/about_welcome_android.css (right): https://codereview.chromium.org/575213002/diff/40001/chrome/browser/resources/about_welcome_android/about_welcome_android.css#newcode51 chrome/browser/resources/about_welcome_android/about_welcome_android.css:51: color: #fff; nit: white
6 years, 3 months ago (2014-09-23 05:57:49 UTC) #19
mmccoy
Thanks for the review, Dan. https://codereview.chromium.org/575213002/diff/40001/chrome/browser/resources/about_welcome_android/about_welcome_android.css File chrome/browser/resources/about_welcome_android/about_welcome_android.css (right): https://codereview.chromium.org/575213002/diff/40001/chrome/browser/resources/about_welcome_android/about_welcome_android.css#newcode51 chrome/browser/resources/about_welcome_android/about_welcome_android.css:51: color: #fff; On 2014/09/23 ...
6 years, 3 months ago (2014-09-23 14:19:33 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/575213002/60001
6 years, 3 months ago (2014-09-23 14:27:25 UTC) #22
commit-bot: I haz the power
Committed patchset #4 (id:60001) as b01559b0baa1732564a03412de5663d57ef945a4
6 years, 3 months ago (2014-09-23 15:07:24 UTC) #23
commit-bot: I haz the power
6 years, 3 months ago (2014-09-23 15:08:08 UTC) #24
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/5ce3577e3fb5e043dc13229c06423823c60f7abc
Cr-Commit-Position: refs/heads/master@{#296186}

Powered by Google App Engine
This is Rietveld 408576698