content/browser/web_contents/aura/overscroll_navigation_overlay.h - Issue 575203002: Use entry URLs instead of entry IDs to determine when to dismiss the overscroll overlay.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/aura/overscroll_navigation_overlay.h

Issue 575203002: Use entry URLs instead of entry IDs to determine when to dismiss the overscroll overlay. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: "Check entry's URL in DoesEntryMatchURL for the sake of uni tests. Also fixing a nit. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/web_contents/aura/overscroll_navigation_overlay.h

diff --git a/content/browser/web_contents/aura/overscroll_navigation_overlay.h b/content/browser/web_contents/aura/overscroll_navigation_overlay.h

index e8e917136ca9866d5710c5bec0128c0da1b42e6e..ccef1bf47886a1193be3cb9cc164bd6dc322b260 100644

--- a/content/browser/web_contents/aura/overscroll_navigation_overlay.h

+++ b/content/browser/web_contents/aura/overscroll_navigation_overlay.h

@@ -101,10 +101,10 @@ class CONTENT_EXPORT OverscrollNavigationOverlay

bool loading_complete_;

bool received_paint_update_;

- // Unique ID of the NavigationEntry we are navigating to. This is needed to

+ // URL of the NavigationEntry we are navigating to. This is needed to

// filter on WebContentsObserver callbacks and is used to dismiss the overlay

// when the relevant page loads and paints.

- int pending_entry_id_;

+ GURL pending_entry_url_;

// The |WindowSlider| that allows sliding history layers while the page is

// being reloaded.

« no previous file with comments | « no previous file | content/browser/web_contents/aura/overscroll_navigation_overlay.cc » ('j') | no next file with comments »