Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 575193002: Add pepper OWNERS to chrome/common/pepper_* (Closed)

Created:
6 years, 3 months ago by elijahtaylor1
Modified:
6 years, 3 months ago
CC:
chromium-reviews, bbudge, brettw, dmichael (off chromium), raymes, teravest
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add pepper OWNERS to chrome/common/pepper_* BUG=None Committed: https://crrev.com/6393bc127b79cc3445014cf8ffb46cde14e43316 Cr-Commit-Position: refs/heads/master@{#295724}

Patch Set 1 #

Patch Set 2 : remove brettw #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M chrome/common/OWNERS View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (4 generated)
elijahtaylor1
Hi folks (added new potential OWNERS to CC), chrome/OWNERS has been catching these files, and ...
6 years, 3 months ago (2014-09-17 21:03:10 UTC) #2
brettw
Don't add me, I'm not doing much pepper reviews any more.
6 years, 3 months ago (2014-09-17 21:19:14 UTC) #4
sky
+yzshen +viettrunglu does this list make sense to you guys?
6 years, 3 months ago (2014-09-17 21:53:35 UTC) #6
yzshen1
On 2014/09/17 21:53:35, sky wrote: > +yzshen > +viettrunglu > does this list make sense ...
6 years, 3 months ago (2014-09-17 22:29:05 UTC) #7
sky
Ok, I'm LGTMing then. Anyone that doesn't want to be in the OWNERs file can ...
6 years, 3 months ago (2014-09-17 22:35:16 UTC) #8
elijahtaylor1
On 2014/09/17 22:35:16, sky wrote: > Ok, I'm LGTMing then. Anyone that doesn't want to ...
6 years, 3 months ago (2014-09-17 22:39:53 UTC) #9
elijahtaylor1
On 2014/09/17 22:39:53, elijahtaylor1 wrote: > On 2014/09/17 22:35:16, sky wrote: > > Ok, I'm ...
6 years, 3 months ago (2014-09-19 00:33:06 UTC) #10
sky
I thought my earlier LGTM covered it. Looks like not.
6 years, 3 months ago (2014-09-19 02:53:54 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/575193002/20001
6 years, 3 months ago (2014-09-19 16:53:29 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 5a2d522083b7846a619ded4a244c172f8a167b49
6 years, 3 months ago (2014-09-19 17:28:13 UTC) #14
commit-bot: I haz the power
6 years, 3 months ago (2014-09-19 17:28:48 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6393bc127b79cc3445014cf8ffb46cde14e43316
Cr-Commit-Position: refs/heads/master@{#295724}

Powered by Google App Engine
This is Rietveld 408576698