Use SkImage::NewFromGenerator() instead of SkImage::newEncodedData()

Use SkImage::NewFromGenerator() instead of SkImage::newEncodedData()

BUG=skia:2948
Committed: https://skia.googlesource.com/skia/+/4bcc2021ffd74ebdf19c5a0f368151b6e680bbe2

[Rémi Piotaix, 2014-09-17 20:52:25]

piotaixr@chromium.org changed reviewers:
+ junov@chromium.org, reed@google.com

[Rémi Piotaix, 2014-09-17 20:52:39]

PTAL

[reed1, 2014-09-17 20:56:51]

https://codereview.chromium.org/575173002/diff/1/src/utils/SkLua.cpp
File src/utils/SkLua.cpp (right):

https://codereview.chromium.org/575173002/diff/1/src/utils/SkLua.cpp#newcode1465
src/utils/SkLua.cpp:1465: SkDecodingImageGenerator::Create(data,
SkDecodingImageGenerator::Options()));
This Create can return null. Perhaps we should check for that before calling
NewFromGenerator

[Rémi Piotaix, 2014-09-17 21:06:55]

https://codereview.chromium.org/575173002/diff/1/src/utils/SkLua.cpp
File src/utils/SkLua.cpp (right):

https://codereview.chromium.org/575173002/diff/1/src/utils/SkLua.cpp#newcode1465
src/utils/SkLua.cpp:1465: SkDecodingImageGenerator::Create(data,
SkDecodingImageGenerator::Options()));
On 2014/09/17 20:56:51, reed1 wrote:
> This Create can return null. Perhaps we should check for that before calling
> NewFromGenerator

I think it is checked in SkInstallDiscardablePixelRef.

[reed1, 2014-09-17 21:24:33]

ok

lgtm

[Rémi Piotaix, 2014-09-17 21:25:11]

The CQ bit was checked by piotaixr@chromium.org

[commit-bot: I haz the power, 2014-09-17 21:26:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/575173002/1

[commit-bot: I haz the power, 2014-09-17 21:33:38]

Committed patchset #1 (id:1) as 4bcc2021ffd74ebdf19c5a0f368151b6e680bbe2