Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 575163002: Remove watchdog from RemoteAnalysisServerImpl (Closed)

Created:
6 years, 3 months ago by jwren
Modified:
6 years, 3 months ago
Reviewers:
danrubel
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Remove watchdog from RemoteAnalysisServerImpl R=danrubel@google.com Committed: https://code.google.com/p/dart/source/detail?r=40400

Patch Set 1 #

Total comments: 6

Patch Set 2 : #

Messages

Total messages: 6 (1 generated)
jwren
6 years, 3 months ago (2014-09-17 20:46:21 UTC) #2
danrubel
Lgtm. Thanks! https://codereview.chromium.org/575163002/diff/1/editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/AnalysisServer.java File editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/AnalysisServer.java (right): https://codereview.chromium.org/575163002/diff/1/editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/AnalysisServer.java#newcode402 editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/AnalysisServer.java:402: * Remove extra comment line https://codereview.chromium.org/575163002/diff/1/editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/internal/remote/RemoteAnalysisServerImplTest.java File ...
6 years, 3 months ago (2014-09-17 20:49:37 UTC) #3
jwren
https://codereview.chromium.org/575163002/diff/1/editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/AnalysisServer.java File editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/AnalysisServer.java (right): https://codereview.chromium.org/575163002/diff/1/editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/AnalysisServer.java#newcode402 editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/AnalysisServer.java:402: * On 2014/09/17 20:49:36, danrubel wrote: > Remove extra ...
6 years, 3 months ago (2014-09-17 20:52:06 UTC) #4
jwren
6 years, 3 months ago (2014-09-17 20:53:08 UTC) #5
jwren
6 years, 3 months ago (2014-09-17 20:53:28 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 40400 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698