Move Webstore URL concepts to //extensions

Move Webstore URL concepts to //extensions and out
of Chrome-specific "constants."

These URLs can be overridden by extensions embedders now
and are no longer incorrectly classified as "constants."

BUG=398671
TBR=xiyuan@chromium.org,sky@chromium.org for various files with header updates

Committed: https://crrev.com/9065985da2ce2a4f73150ac5eabab29c5d67505d
Cr-Commit-Position: refs/heads/master@{#295523}

[Ken Rockot(use gerrit already), 2014-09-17 19:52:49]

Patchset #1 (id:1) has been deleted

[Ken Rockot(use gerrit already), 2014-09-17 20:22:29]

Patchset #2 (id:40001) has been deleted

[Ken Rockot(use gerrit already), 2014-09-17 20:23:26]

rockot@chromium.org changed reviewers:
+ asargent@chromium.org

[Ken Rockot(use gerrit already), 2014-09-17 20:23:27]

Antony could you please review this? Please don't be intimidated by the CL size!
Patch set 1 contains all of the potentially interesting changes

Patch set 2 is strictly header updates around the code base to support the new
location of these functions.

[asargent_no_longer_on_chrome, 2014-09-17 21:41:32]

It seems like kind of a shame that we still have the constant string
"https://chrome.google.com/webstore" duplicated 3 times, in
shell_extensions_client.cc, test_extensions_client.cc, and
chrome_extensions_client.cc. Also I see duplicates of
"https://clients2.google.com/service/update2/crx" in shell_extensions_client.cc
and test_extensions_client.cc. Should we have some sort of default_urls.{h,cc}
file that these client impl's can reference? Or alternatively have a default
implementation of the GetWebstoreBaseURL()/GetWebstoreUpdateURL() methods in
ExtensionsClient. (But that would change ExtensionsClient from pure virtual; not
sure if that is a big deal or not.)

https://codereview.chromium.org/575113002/diff/20001/extensions/common/extens...
File extensions/common/extension_urls.h (right):

https://codereview.chromium.org/575113002/diff/20001/extensions/common/extens...
extensions/common/extension_urls.h:39: std::string GetExtensionGalleryURL();
A long time ago we renamed the "extensions gallery" to the "webstore", so we
should probably try to excise the term "gallery" from the client code as
opportunities present themselves. 

So this might be better named something like "GetWebstoreExtensionCategoryURL"

https://codereview.chromium.org/575113002/diff/20001/extensions/common/extens...
extensions/common/extension_urls.h:54: // |hl| is the host language code, e.g.
en_US. Both arguments will be escaped
nit: consider renaming hl to host_language_code

[Ken Rockot(use gerrit already), 2014-09-17 22:04:30]

Thanks. Added constants to extension_urls.h/cc instead of duplicating in many
places. Other comments addressed inline.

https://codereview.chromium.org/575113002/diff/20001/extensions/common/extens...
File extensions/common/extension_urls.h (right):

https://codereview.chromium.org/575113002/diff/20001/extensions/common/extens...
extensions/common/extension_urls.h:39: std::string GetExtensionGalleryURL();
On 2014/09/17 21:41:32, asargent wrote:
> A long time ago we renamed the "extensions gallery" to the "webstore", so we
> should probably try to excise the term "gallery" from the client code as
> opportunities present themselves. 
> 
> So this might be better named something like "GetWebstoreExtensionCategoryURL"
> 

Done.

https://codereview.chromium.org/575113002/diff/20001/extensions/common/extens...
extensions/common/extension_urls.h:54: // |hl| is the host language code, e.g.
en_US. Both arguments will be escaped
On 2014/09/17 21:41:32, asargent wrote:
> nit: consider renaming hl to host_language_code

Done.

[asargent_no_longer_on_chrome, 2014-09-17 22:24:37]

lgtm

https://codereview.chromium.org/575113002/diff/80001/extensions/common/extens...
File extensions/common/extension_urls.h (right):

https://codereview.chromium.org/575113002/diff/80001/extensions/common/extens...
extensions/common/extension_urls.h:37:
"https://clients2.google.com/service/update2/crx";
as mentioned in person, make sure to move definition to .cc file

[Ken Rockot(use gerrit already), 2014-09-17 22:28:14]

On 2014/09/17 22:24:37, asargent wrote:
> lgtm
> 
>
https://codereview.chromium.org/575113002/diff/80001/extensions/common/extens...
> File extensions/common/extension_urls.h (right):
> 
>
https://codereview.chromium.org/575113002/diff/80001/extensions/common/extens...
> extensions/common/extension_urls.h:37:
> "https://clients2.google.com/service/update2/crx";
> as mentioned in person, make sure to move definition to .cc file

It appears that rietveld has been affected by some minor glitch in the spacetime
backend service
wherein I managed to address your comment before it was posted.

[Ken Rockot(use gerrit already), 2014-09-17 22:30:44]

The CQ bit was checked by rockot@chromium.org

[commit-bot: I haz the power, 2014-09-17 22:31:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/575113002/100001

[commit-bot: I haz the power, 2014-09-17 22:48:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-17 22:48:16]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ken Rockot(use gerrit already), 2014-09-17 22:51:16]

The CQ bit was checked by rockot@chromium.org

[commit-bot: I haz the power, 2014-09-17 22:52:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/575113002/120001

[commit-bot: I haz the power, 2014-09-18 01:00:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-18 01:00:24]

Try jobs failed on following builders:
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)

[Ken Rockot(use gerrit already), 2014-09-18 01:03:18]

The CQ bit was checked by rockot@chromium.org

[commit-bot: I haz the power, 2014-09-18 01:04:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/575113002/120001

[commit-bot: I haz the power, 2014-09-18 03:11:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-18 03:11:31]

Try jobs failed on following builders:
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)

[Ken Rockot(use gerrit already), 2014-09-18 03:12:50]

The CQ bit was checked by rockot@chromium.org

[commit-bot: I haz the power, 2014-09-18 03:13:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/575113002/120001

[commit-bot: I haz the power, 2014-09-18 05:19:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-18 05:19:41]

Try jobs failed on following builders:
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)

[Ken Rockot(use gerrit already), 2014-09-18 06:59:29]

The CQ bit was checked by rockot@chromium.org

[commit-bot: I haz the power, 2014-09-18 07:00:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/575113002/120001

[commit-bot: I haz the power, 2014-09-18 09:05:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-18 09:05:07]

Try jobs failed on following builders:
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)

[Ken Rockot(use gerrit already), 2014-09-18 14:39:53]

The CQ bit was checked by rockot@chromium.org

[commit-bot: I haz the power, 2014-09-18 14:40:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/575113002/120001

[Ken Rockot(use gerrit already), 2014-09-18 15:47:57]

The CQ bit was checked by rockot@chromium.org

[commit-bot: I haz the power, 2014-09-18 15:48:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/575113002/140001

[commit-bot: I haz the power, 2014-09-18 18:00:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-18 18:00:21]

Try jobs failed on following builders:
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)

[Ken Rockot(use gerrit already), 2014-09-18 18:47:23]

The CQ bit was checked by rockot@chromium.org

[commit-bot: I haz the power, 2014-09-18 18:48:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/575113002/160001

[commit-bot: I haz the power, 2014-09-18 19:32:13]

Committed patchset #7 (id:160001) as ccd38187849e94e645acf5514096baa3660f4d82

[commit-bot: I haz the power, 2014-09-18 19:32:47]

Patchset 7 (id:??) landed as
https://crrev.com/9065985da2ce2a4f73150ac5eabab29c5d67505d
Cr-Commit-Position: refs/heads/master@{#295523}