Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 575093003: Revert of Track the active ExtensionKeybindingRegistry and make it available to EventRewriter. (Closed)

Created:
6 years, 3 months ago by Elliot Glaysher
Modified:
6 years, 3 months ago
Reviewers:
Finnur, Devlin, David Tseng, sky
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, tfarina, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, dmazzoni, Peter Lundblad
Base URL:
https://chromium.googlesource.com/chromium/src.git@lkcr
Project:
chromium
Visibility:
Public.

Description

Revert of Track the active ExtensionKeybindingRegistry and make it available to EventRewriter. (patchset #22 id:480001 of https://codereview.chromium.org/553243002/) Reason for revert: The new tests fail on Linux Chromeos (ozone). http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Ozone%20Tests%20%282%29/builds/1998/steps/interactive_ui_tests/logs/ChromeOSConversions Original issue's description: > Track the active ExtensionKeybindingRegistry and make it available to EventRewriter. > > Add the ability to query globally if a shortcut > is registered by an extension and use that to avoid unnecessarily rewriting > Chrome OS keys. > > BUG=410944 > > Committed: https://crrev.com/4264d2c4b5d217e1c5dbc2ae80ab6ce595f9b6d3 > Cr-Commit-Position: refs/heads/master@{#295284} TBR=finnur@chromium.org,sky@chromium.org,rdevlin.cronin@chromium.org,dtseng@chromium.org NOTREECHECKS=true NOTRY=true BUG=410944 Committed: https://crrev.com/5496d52ba9a1d3d8e033dcc5b2a8184626345a08 Cr-Commit-Position: refs/heads/master@{#295324}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -179 lines) Patch
M chrome/browser/chromeos/events/event_rewriter.cc View 3 chunks +0 lines, -25 lines 0 comments Download
M chrome/browser/extensions/extension_commands_global_registry.h View 2 chunks +0 lines, -21 lines 0 comments Download
M chrome/browser/extensions/extension_commands_global_registry.cc View 2 chunks +1 line, -9 lines 0 comments Download
M chrome/browser/extensions/extension_keybinding_apitest.cc View 2 chunks +0 lines, -32 lines 0 comments Download
M chrome/browser/extensions/extension_keybinding_registry.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/profiles/profile_manager.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/toolbar/browser_actions_container.h View 3 chunks +1 line, -6 lines 0 comments Download
M chrome/browser/ui/views/toolbar/browser_actions_container.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/toolbar/toolbar_view.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/toolbar/toolbar_view.cc View 2 chunks +2 lines, -19 lines 0 comments Download
D chrome/test/data/extensions/api_test/keybinding/chromeos_conversions/background.js View 1 chunk +0 lines, -21 lines 0 comments Download
D chrome/test/data/extensions/api_test/keybinding/chromeos_conversions/manifest.json View 1 chunk +0 lines, -34 lines 0 comments Download
M ui/aura/test/ui_controls_factory_aurax11.cc View 4 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Elliot Glaysher
Created Revert of Track the active ExtensionKeybindingRegistry and make it available to EventRewriter.
6 years, 3 months ago (2014-09-17 19:43:41 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/575093003/1
6 years, 3 months ago (2014-09-17 19:44:34 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as a148a7ff017e9d43755fe453ee61dc6acc93dfb5
6 years, 3 months ago (2014-09-17 19:46:34 UTC) #3
commit-bot: I haz the power
6 years, 3 months ago (2014-09-17 19:47:08 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5496d52ba9a1d3d8e033dcc5b2a8184626345a08
Cr-Commit-Position: refs/heads/master@{#295324}

Powered by Google App Engine
This is Rietveld 408576698