Chromium Code Reviews

Issue 575083002: Cleanup class parsing a bit (Closed)

Created:
6 years, 3 months ago by arv (Not doing code reviews)
Modified:
6 years, 3 months ago
Reviewers:
marja
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Cleanup class parsing a bit BUG=v8:3330 LOG=Y R=marja@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24051

Patch Set 1 #

Total comments: 1

Patch Set 2 : Git rebase #

Unified diffs Side-by-side diffs Stats (+47 lines, -40 lines)
M src/ast.h View 2 chunks +7 lines, -13 lines 0 comments
M src/parser.h View 2 chunks +6 lines, -1 line 0 comments
M src/parser.cc View 2 chunks +9 lines, -2 lines 0 comments
M src/preparser.h View 9 chunks +25 lines, -24 lines 0 comments

Messages

Total messages: 9 (3 generated)
arv (Not doing code reviews)
https://codereview.chromium.org/575083002/diff/1/src/ast.h File src/ast.h (left): https://codereview.chromium.org/575083002/diff/1/src/ast.h#oldcode2529 src/ast.h:2529: Handle<String> name_; These are not used. We can add ...
6 years, 3 months ago (2014-09-17 19:24:16 UTC) #2
marja
lgtm
6 years, 3 months ago (2014-09-18 07:15:05 UTC) #3
arv (Not doing code reviews)
Git rebase
6 years, 3 months ago (2014-09-18 17:18:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/575083002/20001
6 years, 3 months ago (2014-09-18 17:38:42 UTC) #6
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 3 months ago (2014-09-18 17:38:43 UTC) #8
arv (Not doing code reviews)
6 years, 3 months ago (2014-09-18 17:39:55 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as 24051 (presubmit successful).

Powered by Google App Engine