Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 575033004: Add exception_port_tool (Closed)

Created:
6 years, 3 months ago by Mark Mentovai
Modified:
6 years, 3 months ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Project:
crashpad
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 5

Patch Set 2 : Address review feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+605 lines, -0 lines) Patch
A tools/exception_port_tool.cc View 1 1 chunk +589 lines, -0 lines 0 comments Download
M tools/tools.gyp View 1 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Mark Mentovai
This tool has been very useful in developing bpoop. The -p option is especially powerful.
6 years, 3 months ago (2014-09-17 14:28:00 UTC) #2
Robert Sesek
https://codereview.chromium.org/575033004/diff/1/tools/exception_port_tool.cc File tools/exception_port_tool.cc (right): https://codereview.chromium.org/575033004/diff/1/tools/exception_port_tool.cc#newcode83 tools/exception_port_tool.cc:83: } else { return false; } ? https://codereview.chromium.org/575033004/diff/1/tools/exception_port_tool.cc#newcode131 tools/exception_port_tool.cc:131: ...
6 years, 3 months ago (2014-09-18 14:43:48 UTC) #3
Mark Mentovai
Great feedback, thanks!
6 years, 3 months ago (2014-09-18 15:55:01 UTC) #5
Robert Sesek
LGTM
6 years, 3 months ago (2014-09-18 16:06:50 UTC) #6
Mark Mentovai
6 years, 3 months ago (2014-09-18 16:09:03 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:40001) manually as 1b61c90 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698