Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 57503002: non_compiled_schema_files should trigger genapi_bundle. (Closed)

Created:
7 years, 1 month ago by xiyuan
Modified:
7 years, 1 month ago
CC:
chromium-reviews
Visibility:
Public.

Description

non_compiled_schema_files should trigger genapi_bundle. Changes in non_compiled_schema_files should trigger genapi_bundle action as well. BUG= R=kalman@chromium.org, miket@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232781

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M build/json_schema_bundle_compile.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
xiyuan
7 years, 1 month ago (2013-11-03 22:36:14 UTC) #1
xiyuan
+kalman Looks like a side effect of r230478 (https://codereview.chromium.org/24449006).
7 years, 1 month ago (2013-11-04 05:39:03 UTC) #2
not at google - send to devlin
ah, thank you.
7 years, 1 month ago (2013-11-04 15:25:02 UTC) #3
not at google - send to devlin
lgtm
7 years, 1 month ago (2013-11-04 15:25:08 UTC) #4
miket_OOO
Thanks! LGTM
7 years, 1 month ago (2013-11-04 17:35:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xiyuan@chromium.org/57503002/1
7 years, 1 month ago (2013-11-04 18:01:25 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) content_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=218674
7 years, 1 month ago (2013-11-04 20:27:32 UTC) #7
xiyuan
7 years, 1 month ago (2013-11-04 20:31:32 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 manually as r232781 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698