Chromium Code Reviews
DescriptionRevert of Second attempt to land change to remove NativeViewportService and (patchset #9 id:160001 of https://codereview.chromium.org/568883003/)
Reason for revert:
This CL caused timeouts on the following tests:
ViewManagerTest.SetViewVisibility
ViewManagerTest.SecondEmbedRoot_Service
ViewManagerTest.EmbedWithSameViewId2
ViewManagerTest.EmbedWithSameViewId
ViewManagerTest.CantGetViewTreeOfOtherRoots
ViewManagerTest.SetViewVisibilityNotifications
ViewManagerTest.SetViewBounds
ViewManagerTest.ViewHierarchyChangedAddingKnownToUnknown
ViewManagerTest.GetViewTree
ViewManagerTest.MultipleEmbedRootsBeforeWTHReady
ViewManagerTest.ReuseDeletedViewId
ViewManagerTest.CantRemoveViewsInOtherRoots
ViewManagerTest.ReorderView
ViewManagerTest.DeleteViewFromAnotherConnectionDisallowed
ViewManagerTest.DeleteView
ViewManagerTest.OnViewInput
ViewManagerTest.CantMoveViewsFromOtherRoot
ViewManagerTest.SecondEmbedRoot_InitService
ViewManagerTest.AddToRoot
ViewManagerTest.ViewHierarchyChangedViews
on Linux and Windows builders.
Original issue's description:
> Second attempt to land change to remove NativeViewportService and
> ViewManager from mojo_shell. First attempt here:
> https://codereview.chromium.org/477923004/
>
> Failed the linux gn dbg build after cq landed:
> http://build.chromium.org/p/chromium.linux/builders/Linux%20GN%20%28dbg%29/builds/12251
>
> BUG=
> TBR=ben@chromium.org
>
> Committed: https://crrev.com/d3e622b0bb31f20c274bc9ad634b8ee7bae99ac1
> Cr-Commit-Position: refs/heads/master@{#295230}
TBR=jamesr@chromium.org,davemoore@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=
Patch Set 1 #
Created: 6 years, 3 months ago
(Patch set is too large to download)
Messages
Total messages: 5 (1 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||