Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 574993002: Revert of Second attempt to land change to remove NativeViewportService and (Closed)

Created:
6 years, 3 months ago by battre
Modified:
6 years, 3 months ago
Reviewers:
jamesr, DaveMoore
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Second attempt to land change to remove NativeViewportService and (patchset #9 id:160001 of https://codereview.chromium.org/568883003/) Reason for revert: This CL caused timeouts on the following tests: ViewManagerTest.SetViewVisibility ViewManagerTest.SecondEmbedRoot_Service ViewManagerTest.EmbedWithSameViewId2 ViewManagerTest.EmbedWithSameViewId ViewManagerTest.CantGetViewTreeOfOtherRoots ViewManagerTest.SetViewVisibilityNotifications ViewManagerTest.SetViewBounds ViewManagerTest.ViewHierarchyChangedAddingKnownToUnknown ViewManagerTest.GetViewTree ViewManagerTest.MultipleEmbedRootsBeforeWTHReady ViewManagerTest.ReuseDeletedViewId ViewManagerTest.CantRemoveViewsInOtherRoots ViewManagerTest.ReorderView ViewManagerTest.DeleteViewFromAnotherConnectionDisallowed ViewManagerTest.DeleteView ViewManagerTest.OnViewInput ViewManagerTest.CantMoveViewsFromOtherRoot ViewManagerTest.SecondEmbedRoot_InitService ViewManagerTest.AddToRoot ViewManagerTest.ViewHierarchyChangedViews on Linux and Windows builders. Original issue's description: > Second attempt to land change to remove NativeViewportService and > ViewManager from mojo_shell. First attempt here: > https://codereview.chromium.org/477923004/ > > Failed the linux gn dbg build after cq landed: > http://build.chromium.org/p/chromium.linux/builders/Linux%20GN%20%28dbg%29/builds/12251 > > BUG= > TBR=ben@chromium.org > > Committed: https://crrev.com/d3e622b0bb31f20c274bc9ad634b8ee7bae99ac1 > Cr-Commit-Position: refs/heads/master@{#295230} TBR=jamesr@chromium.org,davemoore@chromium.org NOTREECHECKS=true NOTRY=true BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+171 lines, -262 lines) Patch
M mojo/aura/aura_init.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/mojo.gyp View 10 chunks +37 lines, -14 lines 0 comments Download
M mojo/mojo_examples.gypi View 5 chunks +5 lines, -1 line 0 comments Download
M mojo/mojo_services.gypi View 11 chunks +13 lines, -30 lines 0 comments Download
M mojo/services/BUILD.gn View 2 chunks +1 line, -4 lines 0 comments Download
M mojo/services/html_viewer/DEPS View 1 chunk +0 lines, -2 lines 0 comments Download
M mojo/services/html_viewer/html_viewer.cc View 2 chunks +0 lines, -17 lines 0 comments Download
M mojo/services/native_viewport/BUILD.gn View 3 chunks +10 lines, -16 lines 0 comments Download
M mojo/services/native_viewport/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
D mojo/services/native_viewport/main.cc View 1 chunk +0 lines, -102 lines 0 comments Download
M mojo/services/public/cpp/view_manager/BUILD.gn View 2 chunks +1 line, -4 lines 0 comments Download
M mojo/services/public/cpp/view_manager/lib/BUILD.gn View 1 chunk +8 lines, -7 lines 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view_manager_test_suite.cc View 1 chunk +1 line, -4 lines 0 comments Download
M mojo/services/public/interfaces/native_viewport/native_viewport.mojom View 1 chunk +0 lines, -7 lines 0 comments Download
M mojo/services/view_manager/BUILD.gn View 3 chunks +5 lines, -11 lines 0 comments Download
M mojo/services/view_manager/ids.h View 2 chunks +2 lines, -1 line 0 comments Download
M mojo/services/view_manager/view_manager_unittest.cc View 3 chunks +7 lines, -11 lines 0 comments Download
M mojo/services/window_manager/BUILD.gn View 2 chunks +6 lines, -1 line 0 comments Download
M mojo/shell/BUILD.gn View 4 chunks +29 lines, -5 lines 0 comments Download
M mojo/shell/context.cc View 4 chunks +25 lines, -5 lines 0 comments Download
M mojo/shell/desktop/mojo_main.cc View 3 chunks +16 lines, -14 lines 0 comments Download
M mojo/shell/in_process_dynamic_service_runner.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
battre
Created Revert of Second attempt to land change to remove NativeViewportService and
6 years, 3 months ago (2014-09-17 10:25:31 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/574993002/1
6 years, 3 months ago (2014-09-17 10:26:37 UTC) #2
commit-bot: I haz the power
Failed to apply patch for mojo/aura/aura_init.cc: While running git apply --index -p1; error: patch failed: ...
6 years, 3 months ago (2014-09-17 10:26:55 UTC) #4
battre
6 years, 3 months ago (2014-09-17 10:32:17 UTC) #5
looks like horo@ was faster than me.

Powered by Google App Engine
This is Rietveld 408576698