Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2495)

Issue 574963002: Remove unused sourceData variable in InspectorStyleSheet. (Closed)

Created:
6 years, 3 months ago by Mads Ager (chromium)
Modified:
6 years, 2 months ago
Reviewers:
vsevik, dgozman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

Remove unused sourceData variable in InspectorStyleSheet. Breaks build for targets that treat unused variables as errors. R=dgozman@chromium.org, vsevik@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182145

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M Source/core/inspector/InspectorStyleSheet.cpp View 2 chunks +1 line, -4 lines 0 comments Download

Messages

Total messages: 9 (1 generated)
Mads Ager (chromium)
6 years, 3 months ago (2014-09-17 09:04:23 UTC) #1
dgozman
lgtm
6 years, 3 months ago (2014-09-17 09:26:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/574963002/1
6 years, 3 months ago (2014-09-17 09:30:25 UTC) #4
dgozman
How does original patch did it through CQ? Should we file a bug for that?
6 years, 3 months ago (2014-09-17 09:32:18 UTC) #5
Mads Ager (chromium)
On 2014/09/17 09:32:18, dgozman wrote: > How does original patch did it through CQ? Should ...
6 years, 3 months ago (2014-09-17 09:34:37 UTC) #6
Mads Ager (chromium)
Committed patchset #1 (id:1) manually as 182145 (presubmit successful).
6 years, 3 months ago (2014-09-17 09:39:58 UTC) #7
vsevik
I think this change is wrong. extractSourceData() call has important side effects hence the resulting ...
6 years, 2 months ago (2014-09-30 12:17:53 UTC) #8
vsevik
6 years, 2 months ago (2014-09-30 12:18:17 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/611333002/ by vsevik@chromium.org.

The reason for reverting is: This code is still needed.

Powered by Google App Engine
This is Rietveld 408576698