LayoutTests/fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-all.html - Issue 57493002: Remove 'alphabetic' value from text-underline-position

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-all.html

Issue 57493002: Remove 'alphabetic' value from text-underline-position (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Julien's review (rebased after auto-rebaseline) Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « LayoutTests/fast/css3-text/css3-text-decoration/text-underline-position/style.css ('k') | LayoutTests/fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-all-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE HTML>	1 <!DOCTYPE HTML>

2 <html>	2 <html>

3 <head>	3 <head>

4 <script>	4 <script>

5 if (window.testRunner)	5 if (window.testRunner)

6 testRunner.dumpAsTextWithPixelResults();	6 testRunner.dumpAsTextWithPixelResults();

7 </script>	7 </script>

8 <link rel="stylesheet" type="text/css" href="style.css">	8 <link rel="stylesheet" type="text/css" href="style.css">

9 </head>	9 </head>

10 <body>	10 <body>

11 <p>Test if each value (auto, alphabetic and under) works. Auto defaults to	11 <p>Test if each value (auto and under) works. Auto means the horizontal

12 alphabetic, so they should look the same, that is, the horizontal line	12 line should cross the 'p' letter in the word 'ipsum'. Under should not

13 should cross the 'p' letter in the word 'ipsum'. Under should not cross the	13 cross the 'pii' letter. Bugzilla link: http://webkit.org/b/102795.</p>
	Julien - ping for review 2013/11/05 17:03:58 is 'pii' a new letter? :) is 'pii' a new letter? :)
14 'p' letter. Bugzilla link: http://webkit.org/b/102795.</p>

15

16 <div class="auto">auto lorem ipsum</div>	14 <div class="auto">auto lorem ipsum</div>

17 <div class="alphabetic">alphabetic lorem ipsum</div>

18 <div class="under">under lorem ipsum</div>	15 <div class="under">under lorem ipsum</div>

19 <div class="auto">auto lorem ipsum <span class="under">under lorem ipsum</sp an> <span class="alphabetic">alphabetic lorem ipsum</span></div>	16 <div class="auto">auto lorem ipsum <span class="under">under lorem ipsum</sp an></div>

20 </body>	17 </body>

21 </html>	18 </html>

OLD	NEW