Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 574903003: Remove chrome_child.dll.pdb from isolate file because it's not there on the bots. (Closed)

Created:
6 years, 3 months ago by jam
Modified:
6 years, 3 months ago
Reviewers:
Zhenyao Mo
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove chrome_child.dll.pdb from isolate file because it's not there on the bots. This is breaking after r295514 which enforces that every file listed in an isolate file exists. BUG=414808 R=zmo@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/1fe230bebb74588fa0b2c714f9719ecfbc900b28

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M chrome/telemetry_gpu_test.isolate View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
jam
6 years, 3 months ago (2014-09-18 20:27:12 UTC) #1
jam
6 years, 3 months ago (2014-09-18 20:27:24 UTC) #2
Zhenyao Mo
On 2014/09/18 20:27:24, jam wrote: LGTM
6 years, 3 months ago (2014-09-18 20:28:00 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/1fe230bebb74588fa0b2c714f9719ecfbc900b28 Cr-Commit-Position: refs/heads/master@{#295547}
6 years, 3 months ago (2014-09-18 20:29:07 UTC) #4
jam
6 years, 3 months ago (2014-09-18 20:29:07 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 1fe230b (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698