Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 574873002: Add onGetFamilyName to SkTypeface. (Closed)

Created:
6 years, 3 months ago by bungeman-skia
Modified:
6 years, 3 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Add onGetFamilyName to SkTypeface. This speeds up and documents this particular feature of SkTypeface and also frees up SkFontDescriptor to be used only in serialization. Committed: https://skia.googlesource.com/skia/+/b374d6a62c0259387d90cad74753d8bad9ee1bea

Patch Set 1 #

Patch Set 2 : Add .get() for DirectWrite. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -17 lines) Patch
M include/core/SkTypeface.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/core/SkTypeface.cpp View 2 chunks +5 lines, -4 lines 0 comments Download
M src/fonts/SkGScalerContext.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/fonts/SkGScalerContext.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M src/fonts/SkTestScalerContext.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/fonts/SkTestScalerContext.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M src/ports/SkFontConfigTypeface.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/ports/SkFontHost_fontconfig.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M src/ports/SkFontHost_linux.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M src/ports/SkFontHost_mac.cpp View 2 chunks +5 lines, -0 lines 0 comments Download
M src/ports/SkFontHost_win.cpp View 3 chunks +8 lines, -4 lines 0 comments Download
M src/ports/SkFontMgr_android.cpp View 1 chunk +4 lines, -2 lines 0 comments Download
M src/ports/SkFontMgr_fontconfig.cpp View 2 chunks +8 lines, -0 lines 0 comments Download
M src/ports/SkTypeface_win_dw.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/ports/SkTypeface_win_dw.cpp View 1 2 chunks +9 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
bungeman-skia
6 years, 3 months ago (2014-09-16 22:49:15 UTC) #2
reed1
lgtm
6 years, 3 months ago (2014-09-17 14:34:35 UTC) #3
reed1
I wonder if we should rename the public method to something more startling -- to ...
6 years, 3 months ago (2014-09-17 14:36:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/574873002/20001
6 years, 3 months ago (2014-09-17 14:40:42 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-17 14:49:03 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as b374d6a62c0259387d90cad74753d8bad9ee1bea

Powered by Google App Engine
This is Rietveld 408576698