runtime/vm/stub_code.cc - Issue 574843002: Fix x64 patching of asllocation stub: the pool pointer must be set-up before patching jump is execu…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/stub_code.cc

Issue 574843002: Fix x64 patching of asllocation stub: the pool pointer must be set-up before patching jump is execu… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/stub_code.cc

===================================================================

--- runtime/vm/stub_code.cc (revision 40325)

+++ runtime/vm/stub_code.cc (working copy)

@@ -118,8 +118,10 @@

if (stub.IsNull()) {

Assembler assembler;

const char* name = cls.ToCString();

- uword patch_code_offset =

- StubCode::GenerateAllocationStubForClass(&assembler, cls);

+ uword patch_code_offset = 0;;

+ uword entry_patch_offset = 0;

+ StubCode::GenerateAllocationStubForClass(

+ &assembler, cls, &entry_patch_offset, &patch_code_offset);

stub ^= Code::FinalizeCode(name, &assembler);

stub.set_owner(cls);

cls.set_allocation_stub(stub);

@@ -129,7 +131,7 @@

stub.Disassemble(&formatter);

OS::Print("}\n");

}

- stub.set_entry_patch_pc_offset(0);

+ stub.set_entry_patch_pc_offset(entry_patch_offset);

stub.set_patch_code_pc_offset(patch_code_offset);

}

return stub.raw();

« no previous file with comments | « runtime/vm/stub_code.h ('k') | runtime/vm/stub_code_arm.cc » ('j') | runtime/vm/stub_code_x64.cc » ('J')