Source/bindings/v8/custom/V8BlobCustom.cpp - Issue 57483002: Implement File constructor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/custom/V8BlobCustom.cpp

Issue 57483002: Implement File constructor. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Addressed feedback on tests. Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/v8/custom/V8BlobCustom.cpp

diff --git a/Source/bindings/v8/custom/V8BlobCustom.cpp b/Source/bindings/v8/custom/V8BlobCustom.cpp

index d514a4eff6a71eb5d36f0cdd090baecd2215bb7e..a61dd7dd21f8c5b802b3d0ce2d728876d53f3886 100644

--- a/Source/bindings/v8/custom/V8BlobCustom.cpp

+++ b/Source/bindings/v8/custom/V8BlobCustom.cpp

@@ -50,6 +50,7 @@ void V8Blob::constructorCustom(const v8::FunctionCallbackInfo<v8::Value>& info)

}

v8::Local<v8::Value> firstArg = info[0];

+ // FIXME: handle WebIDL sequences, possibly by using toV8Sequence

Inactive 2013/11/05 00:38:48 Nit: Would be good to indicate the bug number.

pwnall-personal 2013/11/05 01:14:23 Done.

if (!firstArg->IsArray()) {

throwTypeError("First argument of the constructor is not of type Array", info.GetIsolate());

return;