LayoutTests/fast/files/file-constructor.html - Issue 57483002: Implement File constructor.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/files/file-constructor.html

Issue 57483002: Implement File constructor. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Answered feedback, part 2. Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <script src="../js/resources/js-test-pre.js"></script>	4 <script src="../js/resources/js-test-pre.js"></script>

5 </head>	5 </head>

6 <body>	6 <body>

7 <span id="e"></span>	7 <script src="script-tests/file-constructor.js"></script>
	esprehn 2013/11/04 19:28:08 Blah script tests suck, I wish we'd just put the t Blah script tests suck, I wish we'd just put the test in the html file. pwnall-personal 2013/11/04 23:01:21 I agree, separate files are a pain that's not wort Show quoted text On 2013/11/04 19:28:08, esprehn wrote: > Blah script tests suck, I wish we'd just put the test in the html file. I agree, separate files are a pain that's not worth it when the content isn't shared by multiple tests. I inlined {blob,file}-constructor in their tests.
8 <span id="f"></span>	8 <script src="../js/resources/js-test-post.js"></script>
	esprehn 2013/11/04 19:28:08 Remove post.js, ojan is removing it. Remove post.js, ojan is removing it. pwnall-personal 2013/11/04 23:01:21 Done. Show quoted text On 2013/11/04 19:28:08, esprehn wrote: > Remove post.js, ojan is removing it. Done.
9 <script src="YOUR_JS_FILE_HERE"></script>

10 </body>	9 </body>

11 </html>	10 </html>

OLD	NEW