Source/core/fileapi/Blob.idl - Issue 57483002: Implement File constructor.

Side by Side Diff: Source/core/fileapi/Blob.idl

Issue 57483002: Implement File constructor. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Addressed feedback, minus sequence vs array in File/Blob constructor. Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2010 Google Inc. All rights reserved.	2 * Copyright (C) 2010 Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions are	5 * modification, are permitted provided that the following conditions are

6 * met:	6 * met:

7 *	7 *

8 * * Redistributions of source code must retain the above copyright	8 * * Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * * Redistributions in binary form must reproduce the above	10 * * Redistributions in binary form must reproduce the above

(...skipping 13 matching lines...) Expand all Loading...
24 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,	24 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,

25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY	25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY

26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT	26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT

27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE	27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE

28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.	28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

29 */	29 */

30	30

31 [	31 [

32 GlobalContext=Window&WorkerGlobalScope,	32 GlobalContext=Window&WorkerGlobalScope,

33 SpecialWrapFor=File,	33 SpecialWrapFor=File,

34 CustomConstructor,	34 CustomConstructor(optional sequence<any> blobParts, optional BlobPropertyBag options)
Inactive 2013/11/04 18:33:53 No we actually need to keep this one. The File API No we actually need to keep this one. The File API spec does specify a constructor with no argument for Blob: http://dev.w3.org/2006/webapi/FileAPI/#dfn-Blob We only needed to remove the one from File. pwnall-personal 2013/11/04 19:20:53 Done. Sorry, I missed the difference between the Show quoted text On 2013/11/04 18:33:53, Chris Dumez wrote: > No we actually need to keep this one. The File API spec does specify a > constructor with no argument for Blob: > http://dev.w3.org/2006/webapi/FileAPI/#dfn-Blob > > We only needed to remove the one from File. Done. Sorry, I missed the difference between the version with two optional parameters and a no-parameter version. I figured it out now.
35 CustomConstructor(sequence<any> blobParts, optional BlobPropertyBag options)

36 ] interface Blob {	35 ] interface Blob {

37 readonly attribute unsigned long long size;	36 readonly attribute unsigned long long size;

38 readonly attribute DOMString type;	37 readonly attribute DOMString type;

39	38

40 Blob slice(optional long long start, optional long long end, [TreatNullAs=Nu llString, TreatUndefinedAs=NullString] optional DOMString contentType);	39 Blob slice(optional long long start, optional long long end, [TreatNullAs=Nu llString, TreatUndefinedAs=NullString] optional DOMString contentType);

41 };	40 };

42	41

OLD	NEW

« Source/bindings/v8/custom/V8FileCustom.cpp ('K') | « Source/core/fileapi/Blob.cpp ('k') | Source/core/fileapi/BlobBuilder.h » ('j') | no next file with comments »