Implement File constructor.

Source/bindings/v8/custom/V8FileCustom.cpp

 /*
- * Copyright (C) 2012 Google Inc. All rights reserved.
+ * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
  * copyright notice, this list of conditions and the following disclaimer
  * in the documentation and/or other materials provided with the
  * distribution.
  *     * Neither the name of Google Inc. nor the names of its
  * contributors may be used to endorse or promote products derived from
  * this software without specific prior written permission.
  *
  * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
  * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
  * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
  * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
  * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
  * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
  * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "config.h"
-#include "V8Blob.h"
+#include "V8File.h"
 
+#include "RuntimeEnabledFeatures.h"
 #include "bindings/v8/Dictionary.h"
 #include "bindings/v8/V8Binding.h"
 #include "bindings/v8/V8Utilities.h"
 #include "bindings/v8/custom/V8ArrayBufferCustom.h"
 #include "bindings/v8/custom/V8ArrayBufferViewCustom.h"
 #include "core/fileapi/BlobBuilder.h"
 #include "wtf/RefPtr.h"
 
 namespace WebCore {
 
-void V8Blob::constructorCustom(const v8::FunctionCallbackInfo<v8::Value>& info)
+void V8File::constructorCustom(const v8::FunctionCallbackInfo<v8::Value>& info)
 {
-    if (!info.Length()) {
+    if (!RuntimeEnabledFeatures::fileConstructorEnabled()) {
+        throwTypeError("Illegal constructor", info.GetIsolate());
+        return;
+    }
+
+    if (info.Length() < 2) {
+        throwTypeError("Constructor requires at least two arguments", info.GetIsolate());
         RefPtr<Blob> blob = Blob::create();

[Inactive, 2013/11/04 14:13:11]

Why are we creating a blob in the error case?

[pwnall-personal, 2013/11/04 17:16:25]

Done. (Fixed.)

This was an unfortunate mix between a bad copy-paste and me just getting used to
V8 bindings code.

         info.GetReturnValue().Set(toV8(blob.get(), info.Holder(), info.GetIsolate()));
         return;
     }
 
     v8::Local<v8::Value> firstArg = info[0];
     if (!firstArg->IsArray()) {

[Inactive, 2013/11/04 14:13:11]

Actually, the spec says it is a sequence, not an array so we need to be more
permissive than this. You likely want to use toV8Sequence() instead to check
that it is a sequence (e.g. it can be an object than has a length property but
is not an array)

[pwnall-personal, 2013/11/04 17:16:25]

Good point!

I got this from V8BlobCustom, so the Blob constructor is busted as well. Should
I fix both in this CL, or should I file a follow-up bug?

Also, what's the best way of sharing some code between V8BlobCustom and
V8FileCustom?

         throwTypeError("First argument of the constructor is not of type Array", info.GetIsolate());
         return;
     }
 
+    v8::Local<v8::Value> secondArg = info[1];
+    V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<>, fileName, secondArg);
+
     String type;
     String endings = "transparent";
 
-    if (info.Length() > 1) {
-        if (!info[1]->IsObject()) {
-            throwTypeError("Second argument of the constructor is not of type Object", info.GetIsolate());
+    if (info.Length() > 2) {
+        if (!info[2]->IsObject()) {
+            throwTypeError("Third argument of the constructor is not of type Object", info.GetIsolate());
             return;
         }
 
-        V8TRYCATCH_VOID(Dictionary, dictionary, Dictionary(info[1], info.GetIsolate()));
+        V8TRYCATCH_VOID(Dictionary, dictionary, Dictionary(info[2], info.GetIsolate()));
 
         V8TRYCATCH_VOID(bool, containsEndings, dictionary.get("endings", endings));
         if (containsEndings) {
             if (endings != "transparent" && endings != "native") {
                 throwTypeError("The endings property must be either \"transparent\" or \"native\"", info.GetIsolate());
                 return;
             }
         }
 
         V8TRYCATCH_VOID(bool, containsType, dictionary.get("type", type));
@@ skipping 26 matching lines @@
         } else if (V8Blob::HasInstance(item, info.GetIsolate(), worldType(info.GetIsolate()))) {
             Blob* blob = V8Blob::toNative(v8::Handle<v8::Object>::Cast(item));
             ASSERT(blob);
             blobBuilder.append(blob);
         } else {
             V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<>, stringValue, item);
             blobBuilder.append(stringValue, endings);
         }
     }
 
-    RefPtr<Blob> blob = blobBuilder.getBlob(type);
-    info.GetReturnValue().Set(toV8(blob.get(), info.Holder(), info.GetIsolate()));
+    RefPtr<File> file = blobBuilder.getFile(type, fileName, currentTime());
+    info.GetReturnValue().Set(toV8(file.get(), info.Holder(), info.GetIsolate()));
 }
 
 } // namespace WebCore
+