Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3879)

Unified Diff: cc/trees/layer_tree_host_unittest.cc

Issue 574813002: Remove debug logging in LayerTreeHostTestBreakSwapPromise (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/trees/layer_tree_host_unittest.cc
diff --git a/cc/trees/layer_tree_host_unittest.cc b/cc/trees/layer_tree_host_unittest.cc
index 1fd7f6e2355bf15323858f310a34e2dbf61f7a9a..d29b03f90df592ca2892113a12f192dc6eeb0eb6 100644
--- a/cc/trees/layer_tree_host_unittest.cc
+++ b/cc/trees/layer_tree_host_unittest.cc
@@ -4427,19 +4427,11 @@ class TestSwapPromise : public SwapPromise {
virtual ~TestSwapPromise() {
base::AutoLock lock(result_->lock);
- LOG(ERROR) << "~TestSwapPromise() "
- << " did_swap_called " << result_->did_swap_called
- << " did_not_swap_called " << result_->did_not_swap_called
- << " result addr " << result_;
result_->dtor_called = true;
}
virtual void DidSwap(CompositorFrameMetadata* metadata) OVERRIDE {
base::AutoLock lock(result_->lock);
- LOG(ERROR) << "TestSwapPromise::DidSwap "
- << " did_swap_called " << result_->did_swap_called
- << " did_not_swap_called " << result_->did_not_swap_called
- << " result addr " << result_;
EXPECT_FALSE(result_->did_swap_called);
EXPECT_FALSE(result_->did_not_swap_called);
result_->did_swap_called = true;
@@ -4447,11 +4439,6 @@ class TestSwapPromise : public SwapPromise {
virtual void DidNotSwap(DidNotSwapReason reason) OVERRIDE {
base::AutoLock lock(result_->lock);
- LOG(ERROR) << "TestSwapPromise::DidNotSwap "
- << " reason " << reason
- << " did_swap_called " << result_->did_swap_called
- << " did_not_swap_called " << result_->did_not_swap_called
- << " result addr " << result_;
EXPECT_FALSE(result_->did_swap_called);
EXPECT_FALSE(result_->did_not_swap_called);
result_->did_not_swap_called = true;
@@ -4536,8 +4523,6 @@ class LayerTreeHostTestBreakSwapPromise : public LayerTreeHostTest {
TestSwapPromiseResult swap_promise_result_[3];
};
-// TODO(miletus): Flaky test: crbug.com/393995
-// Enabled with verbose logging information.
MULTI_THREAD_TEST_F(LayerTreeHostTestBreakSwapPromise);
class LayerTreeHostTestBreakSwapPromiseForVisibilityAbortedCommit
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698