Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 574773003: Refactor SkPtrSet

Created:
6 years, 3 months ago by f(malita)
Modified:
6 years, 3 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Refactor SkPtrSet * drop the non-template version (not typesafe & not in use) * templatize the base class (now SkTPtrSet) using partial incPtr/decPtr specialization instead of virtual overrides * add an iterator (to be used in SkGPipeWriter) R=mtklein@google.com

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -135 lines) Patch
M gyp/core.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M include/core/SkFlattenable.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/core/SkFlattenable.cpp View 1 chunk +0 lines, -15 lines 0 comments Download
M src/core/SkPtrRecorder.h View 5 chunks +94 lines, -44 lines 0 comments Download
D src/core/SkPtrRecorder.cpp View 1 chunk +0 lines, -74 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698