Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 574753004: lib32/ doesn't exist on OSX x64 build. Update browser_tests accordingly. (Closed)

Created:
6 years, 3 months ago by M-A Ruel
Modified:
6 years, 2 months ago
Reviewers:
Vadim Sh.
CC:
chromium-reviews, jam
Base URL:
https://chromium.googlesource.com/a/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

lib32/ doesn't exist on OSX x64 build. Update browser_tests accordingly. Add nexe to isolate_driver.py. R=vadimsh@chromium.org BUG=415188 Committed: https://crrev.com/7d0e6ece8333edc98c85d1129703f064182b930c Cr-Commit-Position: refs/heads/master@{#296991}

Patch Set 1 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -5 lines) Patch
M chrome/browser_tests.isolate View 1 chunk +10 lines, -4 lines 0 comments Download
M tools/isolate_driver.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
M-A Ruel
A bit late to fix it but here it is.
6 years, 2 months ago (2014-09-26 14:33:17 UTC) #2
Vadim Sh.
lgtm
6 years, 2 months ago (2014-09-26 18:10:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/574753004/20001
6 years, 2 months ago (2014-09-26 18:12:41 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:20001) as 5b8f72869a5a80cfb2b9186d925efc19d5ba1c7a
6 years, 2 months ago (2014-09-26 18:46:28 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-09-26 18:47:14 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7d0e6ece8333edc98c85d1129703f064182b930c
Cr-Commit-Position: refs/heads/master@{#296991}

Powered by Google App Engine
This is Rietveld 408576698