Issue 574753002: Don't use OwnPrototypeChainLength in GetOwnPropertyNames

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 574753002: Don't use OwnPrototypeChainLength in GetOwnPropertyNames (Closed)

Created:
6 years, 3 months ago by Toon Verwaest

Modified:
6 years, 3 months ago

Reviewers:
Igor Sheludko

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Don't use OwnPrototypeChainLength in GetOwnPropertyNames BUG= R=ishell@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23997

Patch Set 2 : Fix #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -72 lines)			Patch
M	src/objects.h	View		2 chunks	+5 lines, -7 lines	0 comments	Download
M	src/objects.cc	View	1	3 chunks	+22 lines, -22 lines	0 comments	Download
M	src/runtime.cc	View		5 chunks	+10 lines, -43 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Igor Sheludko

lgtm, once comment is addressed https://codereview.chromium.org/574753002/diff/1/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/574753002/diff/1/src/objects.cc#newcode15228 src/objects.cc:15228: storage->SortPairs(storage, index); index + ...

6 years, 3 months ago (2014-09-17 09:09:50 UTC) #3

Toon Verwaest

6 years, 3 months ago (2014-09-17 09:57:01 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as 23997 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Issue 574753002: Don't use OwnPrototypeChainLength in GetOwnPropertyNames (Closed)

Description

Patch Set 1 #

Patch Set 2 : Fix #

Messages