Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 57473002: Remove HTMLMediaElement::m_sendProgressEvents (Closed)

Created:
7 years, 1 month ago by philipj_slow
Modified:
7 years, 1 month ago
Reviewers:
Mike West
CC:
blink-reviews, nessy, philipj_slow, feature-media-reviews_chromium.org, dglazkov+blink, adamk+blink_chromium.org, vcarbune.chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove HTMLMediaElement::m_sendProgressEvents It is always true, and it appears to have been that way since it was added in 2009 (r40857). BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161245

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -7 lines) Patch
M Source/core/html/HTMLMediaElement.h View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/html/HTMLMediaElement.cpp View 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
philipj_slow
7 years, 1 month ago (2013-11-04 09:40:06 UTC) #1
Mike West
LGTM.
7 years, 1 month ago (2013-11-04 09:48:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/57473002/1
7 years, 1 month ago (2013-11-04 09:51:00 UTC) #3
commit-bot: I haz the power
7 years, 1 month ago (2013-11-04 11:18:10 UTC) #4
Message was sent while issue was closed.
Change committed as 161245

Powered by Google App Engine
This is Rietveld 408576698