Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 574723002: Use `backticks` more uniformly in MachOImage*Reader Doxygen documentation (Closed)

Created:
6 years, 3 months ago by Mark Mentovai
Modified:
6 years, 3 months ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Project:
crashpad
Visibility:
Public.

Description

Use `backticks` more uniformly in MachOImage*Reader Doxygen documentation. R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/84d9952ebf32109f32c2287d02d204554f4c648d

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -18 lines) Patch
M util/mac/mach_o_image_reader.h View 2 chunks +11 lines, -11 lines 2 comments Download
M util/mac/mach_o_image_segment_reader.h View 4 chunks +7 lines, -7 lines 1 comment Download

Messages

Total messages: 6 (1 generated)
Mark Mentovai
OCD
6 years, 3 months ago (2014-09-16 15:55:20 UTC) #2
Robert Sesek
https://codereview.chromium.org/574723002/diff/1/util/mac/mach_o_image_reader.h File util/mac/mach_o_image_reader.h (right): https://codereview.chromium.org/574723002/diff/1/util/mac/mach_o_image_reader.h#newcode109 util/mac/mach_o_image_reader.h:109: //! example, `"__TEXT"`. You have "" here and a ...
6 years, 3 months ago (2014-09-16 21:19:38 UTC) #3
Mark Mentovai
https://codereview.chromium.org/574723002/diff/1/util/mac/mach_o_image_reader.h File util/mac/mach_o_image_reader.h (right): https://codereview.chromium.org/574723002/diff/1/util/mac/mach_o_image_reader.h#newcode109 util/mac/mach_o_image_reader.h:109: //! example, `"__TEXT"`. On 2014/09/16 21:19:37, rsesek wrote: > ...
6 years, 3 months ago (2014-09-16 21:29:56 UTC) #4
Robert Sesek
LGTM
6 years, 3 months ago (2014-09-16 21:35:45 UTC) #5
Mark Mentovai
6 years, 3 months ago (2014-09-16 21:37:45 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as 84d9952 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698