Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 574693003: Use an absolute URL when referencing earcon paths. (Closed)

Created:
6 years, 3 months ago by David Tseng
Modified:
6 years, 3 months ago
Reviewers:
Peter Lundblad
CC:
chromium-reviews, oshima+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nkostylev+watch_chromium.org, yuzo+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, stevenjb+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@lkcr
Project:
chromium
Visibility:
Public.

Description

Use an absolute URL when referencing earcon paths. Necessary with upcoming ChromeVox2 changes. Committed: https://crrev.com/2806f0de39a3f30f8bd93225ecbb868c5ec738e4 Cr-Commit-Position: refs/heads/master@{#295554}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/browser/resources/chromeos/chromevox/host/chrome/earcons_background.js View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
David Tseng
6 years, 3 months ago (2014-09-16 16:59:12 UTC) #2
David Tseng
6 years, 3 months ago (2014-09-18 01:53:15 UTC) #4
Peter Lundblad
lgtm
6 years, 3 months ago (2014-09-18 07:15:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/574693003/1
6 years, 3 months ago (2014-09-18 19:28:27 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as a668419d866784507b4ab2caf13998e92da4f568
6 years, 3 months ago (2014-09-18 21:38:02 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-18 21:38:42 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/2806f0de39a3f30f8bd93225ecbb868c5ec738e4
Cr-Commit-Position: refs/heads/master@{#295554}

Powered by Google App Engine
This is Rietveld 408576698