sdk/lib/_internal/compiler/implementation/mirrors/dart2js_member_mirrors.dart - Issue 574683002: Use ConstExp for storing constants.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/mirrors/dart2js_member_mirrors.dart

Issue 574683002: Use ConstExp for storing constants. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Remove ConstExpBuilder. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« sdk/lib/_internal/compiler/implementation/js_backend/type_variable_handler.dart ('K') | « sdk/lib/_internal/compiler/implementation/mirrors/dart2js_instance_mirrors.dart ('k') | sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirrors.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/mirrors/dart2js_member_mirrors.dart

diff --git a/sdk/lib/_internal/compiler/implementation/mirrors/dart2js_member_mirrors.dart b/sdk/lib/_internal/compiler/implementation/mirrors/dart2js_member_mirrors.dart

index 7f3899ade72e3e31903604a1852811e61be26218..d35780f44bf58ce3baed3a295f40f6d6600b5138 100644

--- a/sdk/lib/_internal/compiler/implementation/mirrors/dart2js_member_mirrors.dart

+++ b/sdk/lib/_internal/compiler/implementation/mirrors/dart2js_member_mirrors.dart

@@ -198,12 +198,13 @@ class Dart2JsParameterMirror extends Dart2JsMemberMirror

// TODO(johnniwinther): Get the constant from the [TreeElements]

// associated with the enclosing method.

ParameterElement parameter = _element;

- Constant constant = mirrorSystem.compiler.constants

+ ConstExp constant = mirrorSystem.compiler.constants

.getConstantForVariable(parameter);

assert(invariant(parameter, constant != null,

message: "Missing constant for parameter "

"$parameter with default value."));

- return _convertConstantToInstanceMirror(mirrorSystem, constant);

+ return _convertConstantToInstanceMirror(mirrorSystem,

+ constant, constant.value);

}

return null;

}