sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart - Issue 574683002: Use ConstExp for storing constants.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart

Issue 574683002: Use ConstExp for storing constants. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Remove ConstExpBuilder. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« sdk/lib/_internal/compiler/implementation/js_backend/type_variable_handler.dart ('K') | « sdk/lib/_internal/compiler/implementation/js_backend/type_variable_handler.dart ('k') | sdk/lib/_internal/compiler/implementation/js_emitter/container_builder.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart

diff --git a/sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart b/sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart

index d887512dc0fb39202e77f5966378aae5c711b53c..f81dda0e94260705f0ceb175fcd790f28f165417 100644

--- a/sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart

+++ b/sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart

@@ -935,7 +935,7 @@ class CodeEmitterTask extends CompilerTask {

// `mapTypeToInterceptor` is handled in [emitMapTypeToInterceptor].

if (element == backend.mapTypeToInterceptor) continue;

compiler.withCurrentElement(element, () {

- Constant initialValue = handler.getInitialValueFor(element);

+ Constant initialValue = handler.getInitialValueFor(element).value;

jsAst.Expression init =

js('$isolateProperties.# = #',

[namer.getNameOfGlobalField(element),