sdk/lib/_internal/compiler/implementation/inferrer/simple_types_inferrer.dart - Issue 574683002: Use ConstExp for storing constants.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/inferrer/simple_types_inferrer.dart

Issue 574683002: Use ConstExp for storing constants. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Remove ConstExpBuilder. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« sdk/lib/_internal/compiler/implementation/dart_backend/backend_ast_emitter.dart ('K') | « sdk/lib/_internal/compiler/implementation/elements/modelx.dart ('k') | sdk/lib/_internal/compiler/implementation/inferrer/type_graph_inferrer.dart » ('j') | sdk/lib/_internal/compiler/implementation/js_backend/type_variable_handler.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/inferrer/simple_types_inferrer.dart

diff --git a/sdk/lib/_internal/compiler/implementation/inferrer/simple_types_inferrer.dart b/sdk/lib/_internal/compiler/implementation/inferrer/simple_types_inferrer.dart

index 8be465c988de1479f01122d7beba06439ffaaf6b..dea77ff12000b85356cd53b22ff9b8defdeed855 100644

--- a/sdk/lib/_internal/compiler/implementation/inferrer/simple_types_inferrer.dart

+++ b/sdk/lib/_internal/compiler/implementation/inferrer/simple_types_inferrer.dart

@@ -984,8 +984,8 @@ class SimpleTypeInferrerVisitor<T>

&& compiler.world.fieldNeverChanges(element)) {

var constant =

compiler.backend.constants.getConstantForVariable(element);

- if (constant != null && constant.isInt) {

- return constant.value;

+ if (constant != null && constant.value.isInt) {

+ return constant.value.value;

sigurdm 2014/09/17 10:29:41 We talked about renaming the "value" field of prim

Johnni Winther 2014/09/17 12:20:40 Added a TODO on [PrimitiveConstant.value].

}

return null;