sdk/lib/_internal/compiler/implementation/cps_ir/constant_propagation.dart - Issue 574683002: Use ConstExp for storing constants.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/cps_ir/constant_propagation.dart

Issue 574683002: Use ConstExp for storing constants. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Remove ConstExpBuilder. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« sdk/lib/_internal/compiler/implementation/constants.dart ('K') | « sdk/lib/_internal/compiler/implementation/cps_ir/const_expression.dart ('k') | sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_builder.dart » ('j') | sdk/lib/_internal/compiler/implementation/dart_backend/backend_ast_emitter.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/cps_ir/constant_propagation.dart

diff --git a/sdk/lib/_internal/compiler/implementation/cps_ir/constant_propagation.dart b/sdk/lib/_internal/compiler/implementation/cps_ir/constant_propagation.dart

index e3321f672e63e71db390e78a1739e26f4f6407cd..c8b1b10801a77bdc68b2b8d8925b2cef55c20ffa 100644

--- a/sdk/lib/_internal/compiler/implementation/cps_ir/constant_propagation.dart

+++ b/sdk/lib/_internal/compiler/implementation/cps_ir/constant_propagation.dart

@@ -79,7 +79,7 @@ class _TransformingVisitor extends RecursiveVisitor {

dart2js.PrimitiveConstant primitiveConstant = cell.constant;

ConstExp constExp = new PrimitiveConstExp(primitiveConstant);

- Constant constant = new Constant(constExp, primitiveConstant);

+ Constant constant = new Constant(constExp);

LetPrim letPrim = new LetPrim(constant);

InvokeContinuation invoke =

new InvokeContinuation(continuation, <Definition>[constant]);