sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirrors.dart - Issue 574683002: Use ConstExp for storing constants.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirrors.dart

Issue 574683002: Use ConstExp for storing constants. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Updated cf. comments. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/mirrors/dart2js_member_mirrors.dart ('k') | sdk/lib/_internal/compiler/implementation/mirrors_used.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirrors.dart

diff --git a/sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirrors.dart b/sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirrors.dart

index c3851f0a92122f0afaafe6367cc7f554269791e0..3e820e4d05802970c32ec16c349d1a3e803c24b2 100644

--- a/sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirrors.dart

+++ b/sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirrors.dart

@@ -6,6 +6,7 @@ library dart2js.mirrors;

import 'dart:collection' show UnmodifiableListView, UnmodifiableMapView;

+import '../cps_ir/const_expression.dart';

import '../elements/elements.dart';

import '../scanner/scannerlib.dart';

import '../resolution/resolution.dart' show Scope;

@@ -221,8 +222,8 @@ abstract class Dart2JsElementMirror extends Dart2JsDeclarationMirror {

_appendCommentTokens(

mirrorSystem.compiler.commentMap[metadata.beginToken]);

metadata.ensureResolved(mirrorSystem.compiler);

- _metadata.add(_convertConstantToInstanceMirror(mirrorSystem,

- metadata.value));

+ _metadata.add(_convertConstantToInstanceMirror(

+ mirrorSystem, metadata.constant, metadata.constant.value));

}

_appendCommentTokens(mirrorSystem.compiler.commentMap[getBeginToken()]);

}