sdk/lib/_internal/compiler/implementation/dart_backend/tree_ir_nodes.dart - Issue 574683002: Use ConstExp for storing constants.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/dart_backend/tree_ir_nodes.dart

Issue 574683002: Use ConstExp for storing constants. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Updated cf. comments. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/dart_backend/tree_ir_builder.dart ('k') | sdk/lib/_internal/compiler/implementation/deferred_load.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/dart_backend/tree_ir_nodes.dart

diff --git a/sdk/lib/_internal/compiler/implementation/dart_backend/tree_ir_nodes.dart b/sdk/lib/_internal/compiler/implementation/dart_backend/tree_ir_nodes.dart

index fd3f677e7e27d25e4ea59157a7fc2517d4141e64..f9f43777c98af1a6f65541d42030e8b532ebdd4d 100644

--- a/sdk/lib/_internal/compiler/implementation/dart_backend/tree_ir_nodes.dart

+++ b/sdk/lib/_internal/compiler/implementation/dart_backend/tree_ir_nodes.dart

@@ -191,15 +191,15 @@ class ConcatenateStrings extends Expression {

class Constant extends Expression {

final ConstExp expression;

- final dart2js.Constant value;

- Constant(this.expression, this.value);

+ Constant(this.expression);

Constant.primitive(dart2js.PrimitiveConstant primitiveValue)

- : expression = new PrimitiveConstExp(primitiveValue),

- value = primitiveValue;

+ : expression = new PrimitiveConstExp(primitiveValue);

accept(ExpressionVisitor visitor) => visitor.visitConstant(this);

+ dart2js.Constant get value => expression.value;

}

class This extends Expression {