Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Unified Diff: tests/compiler/dart2js/backend_dart/sexpr_test.dart

Issue 574683002: Use ConstExp for storing constants. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Fixes and further implementation. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/compiler/dart2js/backend_dart/sexpr_test.dart
diff --git a/tests/compiler/dart2js/backend_dart/sexpr_test.dart b/tests/compiler/dart2js/backend_dart/sexpr_test.dart
index a1304633733062e50577378364efb0f509db1486..9ed629c00a24887c6d6ed446983a14e3578be5a5 100644
--- a/tests/compiler/dart2js/backend_dart/sexpr_test.dart
+++ b/tests/compiler/dart2js/backend_dart/sexpr_test.dart
@@ -137,9 +137,14 @@ Future<List<String>> testStringifier(String code,
/// returns the resulting definitions.
List<FunctionDefinition> testUnstringifier(List<String> sexprs) {
return sexprs.map((String sexpr) {
- final function = new SExpressionUnstringifier().unstringify(sexpr);
- Expect.isNotNull(function, "Unstringification failed:\n\n$sexpr");
- return function;
+ try {
+ final function = new SExpressionUnstringifier().unstringify(sexpr);
+ Expect.isNotNull(function, "Unstringification failed:\n\n$sexpr");
+ return function;
+ } catch (e, s) {
karlklose 2014/09/25 08:43:25 Why this change? Is this debug code or is the stac
Johnni Winther 2014/09/29 08:24:44 On error the unstringifier now throws instead of a
+ print('$e\n$s');
+ Expect.fail('Error unstringifying "$sexpr": $e');
+ }
}).toList();
}

Powered by Google App Engine
This is Rietveld 408576698