sdk/lib/_internal/compiler/implementation/dart_backend/backend_ast_nodes.dart - Issue 574683002: Use ConstExp for storing constants.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/dart_backend/backend_ast_nodes.dart

Issue 574683002: Use ConstExp for storing constants. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Fixes and further implementation. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« sdk/lib/_internal/compiler/implementation/constants.dart ('K') | « sdk/lib/_internal/compiler/implementation/dart_backend/backend_ast_emitter.dart ('k') | sdk/lib/_internal/compiler/implementation/dart_backend/dart_backend.dart » ('j') | sdk/lib/_internal/compiler/implementation/helpers/helpers.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/dart_backend/backend_ast_nodes.dart

diff --git a/sdk/lib/_internal/compiler/implementation/dart_backend/backend_ast_nodes.dart b/sdk/lib/_internal/compiler/implementation/dart_backend/backend_ast_nodes.dart

index 82839d5354081845a431e8a7b0c030d441be0532..f47de50e727f2c5ac46197dac1affa5e9b6e1c7b 100644

--- a/sdk/lib/_internal/compiler/implementation/dart_backend/backend_ast_nodes.dart

+++ b/sdk/lib/_internal/compiler/implementation/dart_backend/backend_ast_nodes.dart

@@ -828,7 +828,9 @@ class Unparser {

write(v.toString());

}

} else {

- write(e.value.toString());

+ // TODO(sigurdm): Use [ConstExp] to generate valid code for any

+ // constant.

+ write(e.value.unparse());

}

} else if (e is LiteralList) {

if (e.isConst) {