sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_tracer.dart - Issue 574683002: Use ConstExp for storing constants.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_tracer.dart

Issue 574683002: Use ConstExp for storing constants. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Fixes and further implementation. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« sdk/lib/_internal/compiler/implementation/constants.dart ('K') | « sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_nodes_sexpr.dart ('k') | sdk/lib/_internal/compiler/implementation/dart2jslib.dart » ('j') | sdk/lib/_internal/compiler/implementation/helpers/helpers.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_tracer.dart

diff --git a/sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_tracer.dart b/sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_tracer.dart

index fb0fd1d0252dfd626f485e2b0da78dfcfd7eeb53..a588bc9d1214260158bfe5c810548ee5e1041051 100644

--- a/sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_tracer.dart

+++ b/sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_tracer.dart

@@ -214,7 +214,7 @@ class IRTracer extends TracerUtil implements cps_ir.Visitor {

String formatPrimitive(cps_ir.Primitive p) => visit(p);

visitConstant(cps_ir.Constant node) {

- return "Constant ${node.value}";

+ return "Constant ${node.expression.value}";

}

visitParameter(cps_ir.Parameter node) {