Use ConstExp for storing constants.

pkg/docgen/lib/src/models/model_helpers.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library docgen.model_helpers;
 
 import 'dart:collection';
 
 import '../exports/dart2js_mirrors.dart' as dart2js_mirrors;
 import '../exports/mirrors_util.dart' as dart2js_util;
@@ skipping 24 matching lines @@
   'constructors': recurseMap(_filterMap(mapToExpand,
       (key, val) => val.mirror.isConstructor)),
   'operators': recurseMap(_filterMap(mapToExpand,
       (key, val) => val.mirror.isOperator)),
   'methods': recurseMap(_filterMap(mapToExpand,
       (key, val) => val.mirror.isRegularMethod && !val.mirror.isOperator))
 };
 
 String getDefaultValue(ParameterMirror mirror) {
   if (!mirror.hasDefaultValue) return null;
-  return getDefaultValueFromConstMirror(mirror.defaultValue);
+  return '${mirror.defaultValue}';
 }
 
-String getDefaultValueFromConstMirror(
-    dart2js_mirrors.Dart2JsConstantMirror valueMirror) {
-
-  if (valueMirror is dart2js_mirrors.Dart2JsStringConstantMirror) {
-    return '"${valueMirror.reflectee}"';
-  }
-
-  if (valueMirror is dart2js_mirrors.Dart2JsListConstantMirror) {
-    var buffer = new StringBuffer('[');
-
-    var values = new Iterable.generate(valueMirror.length,
-        (i) => valueMirror.getElement(i))
-        .map((e) => getDefaultValueFromConstMirror(e));
-
-    buffer.writeAll(values, ', ');
-
-    buffer.write(']');
-    return buffer.toString();
-  }
-
-  if (valueMirror is dart2js_mirrors.Dart2JsMapConstantMirror) {
-    // TODO(kevmoo) Handle non-empty case
-    if (valueMirror.length == 0) return '{}';
-  }
-
-  // TODO(kevmoo) Handle consts of non-core types
-
-  return '${valueMirror}';
-}
-
+// TODO(johnniwinther): Use the `ConstExp` classes instead of `ResolvedNode`.
 /// Returns a list of meta annotations assocated with a mirror.
 List<Annotation> createAnnotations(DeclarationMirror mirror,
     Library owningLibrary) {
   var annotations = [];
   for (dart2js_mirrors.ResolvedNode node in
       dart2js_mirrors.BackDoor.metadataSyntaxOf(mirror)) {
     var docgenAnnotation = new Annotation(node, owningLibrary);
     if (!_SKIPPED_ANNOTATIONS.contains(dart2js_util.qualifiedNameOf(
         docgenAnnotation.mirror))) {
       annotations.add(docgenAnnotation);
@@ skipping 193 matching lines @@
   // the time.
   var sdkLibrary = LIBRARIES[dart2js_util.nameOf(mirror)];
   if (sdkLibrary != null) {
     return !sdkLibrary.documented;
   } else if (dart2js_util.nameOf(mirror).startsWith('_') || dart2js_util.nameOf(
       mirror).contains('._')) {
     return true;
   }
   return false;
 }