Use ConstExp for storing constants.

tests/compiler/dart2js/backend_dart/sexpr_unstringifier.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 // SExpressionUnstringifier implements the inverse operation to
 // [SExpressionStringifier].
 
 library sexpr_unstringifier;
 
 import 'package:compiler/implementation/dart2jslib.dart' as dart2js
-  show Constant, IntConstant, NullConstant, StringConstant,
-       DoubleConstant, TrueConstant, FalseConstant, MessageKind;
+    show Constant, IntConstant, NullConstant, StringConstant,
+         DoubleConstant, TrueConstant, FalseConstant, MessageKind;
 import 'package:compiler/implementation/dart_types.dart' as dart_types
-  show DartType;
+    show DartType;
 import 'package:compiler/implementation/elements/elements.dart'
-  show Entity, Element, Elements, Local, TypeVariableElement, ErroneousElement,
-       TypeDeclarationElement, ExecutableElement;
+   show Entity, Element, Elements, Local, TypeVariableElement, ErroneousElement,
+         TypeDeclarationElement, ExecutableElement;
 import 'package:compiler/implementation/elements/modelx.dart'
-  show ErroneousElementX, TypeVariableElementX;
-import 'package:compiler/implementation/tree/tree.dart'show LiteralDartString;
+    show ErroneousElementX, TypeVariableElementX;
+import 'package:compiler/implementation/tree/tree.dart' show LiteralDartString;
 import 'package:compiler/implementation/universe/universe.dart'
-  show Selector, SelectorKind;
+    show Selector, SelectorKind;
 import 'package:compiler/implementation/cps_ir/cps_ir_nodes.dart';
+import 'package:compiler/implementation/cps_ir/const_expression.dart'
+    show PrimitiveConstExp;
 
 /// Used whenever a node constructed by [SExpressionUnstringifier] needs a
 /// named entity.
 class DummyEntity extends Entity {
   final String name;
   DummyEntity(this.name);
 }
 
 /// Used whenever a node constructed by [SExpressionUnstringifier] needs a
 /// local.
@@ skipping 511 matching lines @@
 
     return null;
   }
 
   /// (Constant (constant))
   Constant parseConstant() {
     tokens.consumeStart(CONSTANT);
     String tag = tokens.read();
 
     // NullConstant.
-    if (tag == "null") {
+    if (tag == "NullConstant") {
       tokens.consumeEnd();
-      return new Constant(null, new dart2js.NullConstant());
+      return new Constant(new PrimitiveConstExp(new dart2js.NullConstant()));
     }
 
     // BoolConstant.
-    if (tag == "true") {
+    if (tag == "BoolConstant") {
+      tokens.consumeStart();
+      tag = tokens.read();
       tokens.consumeEnd();
-      return new Constant(null, new dart2js.TrueConstant());
-    } else if (tag == "false") {
       tokens.consumeEnd();
-      return new Constant(null, new dart2js.FalseConstant());
+      if (tag == "true") {
+        return new Constant(new PrimitiveConstExp(
+            new dart2js.TrueConstant()));
+      } else if (tag == "false") {
+        return new Constant(new PrimitiveConstExp(
+            new dart2js.FalseConstant()));
+      }
+      throw "Invalid bool value '$tag'.";
     }
 
     // StringConstant.
     if (tag == "StringConstant") {
       tokens.consumeStart();
       List<String> strings = <String>[];
       do {
         strings.add(tokens.read());
       } while (tokens.current != ")");
       tokens.consumeEnd();
 
       String string = strings.join(" ");
       assert(string.startsWith('"') && string.endsWith('"'));
 
       dart2js.StringConstant value = new dart2js.StringConstant(
           new LiteralDartString(string.substring(1, string.length - 1)));
 
       tokens.consumeEnd();
-      return new Constant(null, value);
+      return new Constant(new PrimitiveConstExp(value));
     }
 
     // IntConstant.
-    int intValue = int.parse(tag, onError: (_) => null);
-    if (intValue != null) {
+    if (tag == "IntConstant") {
+      tokens.consumeStart();
+      tag = tokens.read();
+      int intValue = int.parse(tag, onError: (_) => null);
+      if (intValue == null) {
+        throw "Invalid int value '$tag'.";
+      }
       tokens.consumeEnd();
-      return new Constant(null, new dart2js.IntConstant(intValue));
+      tokens.consumeEnd();
+      return new Constant(new PrimitiveConstExp(
+          new dart2js.IntConstant(intValue)));
     }
 
     // DoubleConstant.
-    double doubleValue = double.parse(tag, (_) => null);
-    if (doubleValue != null) {
+    if (tag == "DoubleConstant") {
+      tokens.consumeStart();
+      tag = tokens.read();
+      double doubleValue = double.parse(tag, (_) => null);
+      if (doubleValue == null) {
+        throw "Invalid double value '$tag'.";
+      }
       tokens.consumeEnd();
-      return new Constant(null, new dart2js.DoubleConstant(doubleValue));
+      tokens.consumeEnd();
+      return new Constant(new PrimitiveConstExp(
+          new dart2js.DoubleConstant(doubleValue)));
     }
 
-    assert(false);
-    return null;
+    throw "Unhandled tag '$tag'.";
   }
 
   /// (CreateFunction (definition))
   CreateFunction parseCreateFunction() {
     tokens.consumeStart(CREATE_FUNCTION);
     FunctionDefinition def = parseFunctionDefinition();
     tokens.consumeEnd();
     return new CreateFunction(def);
   }
 
@@ skipping 36 matching lines @@
     return new ReifyTypeVar(type);
   }
 
   /// (This)
   This parseThis() {
     tokens.consumeStart(THIS);
     tokens.consumeEnd();
     return new This();
   }
 }