Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(727)

Issue 574653002: Fix typed lowering to number comparison. (Closed)

Created:
6 years, 3 months ago by Michael Starzinger
Modified:
6 years, 3 months ago
Reviewers:
titzer
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Fix typed lowering to number comparison. R=titzer@chromium.org TEST=mjsunit/regress/regress-3564 BUG=v8:3564 LOG=N Committed: https://code.google.com/p/v8/source/detail?r=23972

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -7 lines) Patch
M src/compiler/js-typed-lowering.cc View 1 chunk +3 lines, -1 line 0 comments Download
A + test/mjsunit/regress/regress-3564.js View 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Starzinger
6 years, 3 months ago (2014-09-16 08:21:02 UTC) #1
titzer
lgtm
6 years, 3 months ago (2014-09-16 11:18:31 UTC) #2
Michael Starzinger
6 years, 3 months ago (2014-09-16 11:33:48 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 23972 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698