Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 574643006: Disable delete mismatch on Dr.Memory bot (Closed)

Created:
6 years, 3 months ago by zhaoqin
Modified:
6 years, 3 months ago
Reviewers:
Derek Bruening
CC:
chromium-reviews, glider+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Disable delete mismatch on Dr.Memory bot xref https://code.google.com/p/drmemory/issues/detail?id=1058 R=bruening@chromium.org BUG=413215 NOTRY=true Committed: https://crrev.com/e98b2dc1964cc237248ebb1627be52242d1c55ca Cr-Commit-Position: refs/heads/master@{#295775}

Patch Set 1 #

Total comments: 6

Patch Set 2 : PTAL #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -17 lines) Patch
M tools/valgrind/drmemory/suppressions.txt View 1 2 chunks +3 lines, -12 lines 0 comments Download
M tools/valgrind/drmemory/suppressions_full.txt View 1 chunk +0 lines, -5 lines 0 comments Download
M tools/valgrind/valgrind_test.py View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (1 generated)
zhaoqin
6 years, 3 months ago (2014-09-16 16:36:56 UTC) #1
Derek Bruening
https://codereview.chromium.org/574643006/diff/1/tools/valgrind/drmemory/suppressions.txt File tools/valgrind/drmemory/suppressions.txt (right): https://codereview.chromium.org/574643006/diff/1/tools/valgrind/drmemory/suppressions.txt#newcode261 tools/valgrind/drmemory/suppressions.txt:261: *!scoped_ptr<>* Should this be removed too? It seems awfully ...
6 years, 3 months ago (2014-09-16 17:14:02 UTC) #2
zhaoqin
PTAL https://codereview.chromium.org/574643006/diff/1/tools/valgrind/drmemory/suppressions.txt File tools/valgrind/drmemory/suppressions.txt (right): https://codereview.chromium.org/574643006/diff/1/tools/valgrind/drmemory/suppressions.txt#newcode261 tools/valgrind/drmemory/suppressions.txt:261: *!scoped_ptr<>* On 2014/09/16 17:14:01, Derek Bruening wrote: > ...
6 years, 3 months ago (2014-09-16 18:22:00 UTC) #3
zhaoqin
On 2014/09/16 18:22:00, zhaoqin wrote: > PTAL > > https://codereview.chromium.org/574643006/diff/1/tools/valgrind/drmemory/suppressions.txt > File tools/valgrind/drmemory/suppressions.txt (right): > ...
6 years, 3 months ago (2014-09-17 14:26:13 UTC) #4
Derek Bruening
LGTM
6 years, 3 months ago (2014-09-19 20:57:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/574643006/20001
6 years, 3 months ago (2014-09-19 21:02:19 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 42821b1d481452b037a3e5349f739952e5555b4c
6 years, 3 months ago (2014-09-19 21:04:07 UTC) #8
commit-bot: I haz the power
Failed to apply patch for tools/valgrind/drmemory/suppressions.txt: While running git apply --index -p1; error: patch failed: ...
6 years, 3 months ago (2014-09-19 21:04:08 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-19 21:05:35 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e98b2dc1964cc237248ebb1627be52242d1c55ca
Cr-Commit-Position: refs/heads/master@{#295775}

Powered by Google App Engine
This is Rietveld 408576698