Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Issue 574633002: Revert of Perf: Update size expectation for nacl_helper/nacl_helper on linux (Closed)

Created:
6 years, 3 months ago by nhiroki
Modified:
6 years, 3 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
http://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Perf: Update size expectation for nacl_helper/nacl_helper on linux (patchset #1 id:1 of https://codereview.chromium.org/575603003/) Reason for revert: I should have updated the expectation for linux-release (not linux-release-64). Original issue's description: > Perf: Update size expectation for nacl_helper/nacl_helper on linux > > Regression is tiny (0.04%). > > http://build.chromium.org/p/chromium/builders/Linux/builds/53433 > https://chromeperf.appspot.com/report?masters=Chromium&bots=chromium-rel-linux%2Cchromium-rel-xp&tests=sizes%2Fnacl_helper&rev=294900&checked=all > > TBR=nhiroki@chromium.org > NOTRY=true > > Committed: https://crrev.com/bd700c84bf9132a96e17e0ea724d1855a8d01740 > Cr-Commit-Position: refs/heads/master@{#294991} TBR= NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/6b6f1295e07f0a37ecf45ec983fa7df78e909274 Cr-Commit-Position: refs/heads/master@{#295016}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/perf_expectations/perf_expectations.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
nhiroki
Created Revert of Perf: Update size expectation for nacl_helper/nacl_helper on linux
6 years, 3 months ago (2014-09-16 05:46:32 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/574633002/1
6 years, 3 months ago (2014-09-16 05:47:24 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as be86c11e3e60bf605601306610673e8c7b93c077
6 years, 3 months ago (2014-09-16 05:48:22 UTC) #3
commit-bot: I haz the power
6 years, 3 months ago (2014-09-16 05:49:43 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6b6f1295e07f0a37ecf45ec983fa7df78e909274
Cr-Commit-Position: refs/heads/master@{#295016}

Powered by Google App Engine
This is Rietveld 408576698