Issue 57463011: Don't send the renderer flags that it doesn't use.

Issue 57463011: Don't send the renderer flags that it doesn't use. (Closed)

Created:
7 years, 1 month ago by piman

Modified:
7 years, 1 month ago

Reviewers:
jamesr

CC:
chromium-reviews, joi+watch-content_chromium.org, piman+watch_chromium.org, jam, apatrick_chromium, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Don't send the renderer flags that it doesn't use. BUG=314909 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233542

Patch Set 3 : rebase #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -9 lines)			Patch
	M	content/browser/gpu/gpu_data_manager_impl_private.cc	View	1 2	1 chunk	+0 lines, -8 lines	0 comments	Download
	M	content/browser/renderer_host/render_process_host_impl.cc	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

piman

FYI: $ git gs kDisableExperimentalWebGL android_webview/lib/main/aw_main_delegate.cc:66: cl->AppendSwitch(switches::kDisableExperimentalWebGL); chrome/browser/about_flags.cc:476: SINGLE_VALUE_TYPE(switches::kDisableExperimentalWebGL) chrome/test/gpu/gpu_feature_browsertest.cc:286: command_line->AppendSwitch(switches::kDisableExperimentalWebGL); chrome/test/perf/frame_rate/frame_rate_tests.cc:111: launch_arguments_.AppendSwitch(switches::kDisableExperimentalWebGL); chrome/test/perf/rendering/throughput_tests.cc:198: command_line->AppendSwitch(switches::kDisableExperimentalWebGL); ...

7 years, 1 month ago (2013-11-05 01:41:21 UTC) #1

FYI:

$ git gs kDisableExperimentalWebGL
android_webview/lib/main/aw_main_delegate.cc:66: 
cl->AppendSwitch(switches::kDisableExperimentalWebGL);
chrome/browser/about_flags.cc:476:   
SINGLE_VALUE_TYPE(switches::kDisableExperimentalWebGL)
chrome/test/gpu/gpu_feature_browsertest.cc:286:   
command_line->AppendSwitch(switches::kDisableExperimentalWebGL);
chrome/test/perf/frame_rate/frame_rate_tests.cc:111:     
launch_arguments_.AppendSwitch(switches::kDisableExperimentalWebGL);
chrome/test/perf/rendering/throughput_tests.cc:198:     
command_line->AppendSwitch(switches::kDisableExperimentalWebGL);
content/browser/gpu/compositor_util.cc:88:         
command_line.HasSwitch(switches::kDisableExperimentalWebGL),
content/browser/gpu/gpu_data_manager_impl_private.cc:161:     
command_line.HasSwitch(switches::kDisableExperimentalWebGL),
content/browser/renderer_host/render_view_host_impl.cc:350:     
!command_line.HasSwitch(switches::kDisableExperimentalWebGL);
content/public/common/content_switches.cc:165:const char
kDisableExperimentalWebGL[]      = "disable-webgl";
content/public/common/content_switches.h:60:CONTENT_EXPORT extern const char
kDisableExperimentalWebGL[];

$ git gs kDisableGLMultisampling
chrome/test/gpu/gpu_feature_browsertest.cc:346:   
command_line->AppendSwitch(switches::kDisableGLMultisampling);
content/browser/gpu/compositor_util.cc:95:         
command_line.HasSwitch(switches::kDisableGLMultisampling),
content/browser/gpu/gpu_data_manager_impl.h:102:  // kDisableGLMultisampling.
content/browser/gpu/gpu_data_manager_impl_private.cc:670:     
!command_line->HasSwitch(switches::kDisableGLMultisampling)) {
content/browser/gpu/gpu_data_manager_impl_private.cc:671:   
command_line->AppendSwitch(switches::kDisableGLMultisampling);
content/browser/gpu/gpu_process_host.cc:1124:   
switches::kDisableGLMultisampling,
content/browser/renderer_host/render_view_host_impl.cc:363:     
!command_line.HasSwitch(switches::kDisableGLMultisampling);
content/common/gpu/gpu_channel.cc:459:     
command_line->HasSwitch(switches::kDisableGLMultisampling);
content/public/common/content_switches.cc:195:const char
kDisableGLMultisampling[]        = "disable-gl-multisampling";
content/public/common/content_switches.h:70:CONTENT_EXPORT extern const char
kDisableGLMultisampling[];

$ git gs kDisableAccelerated2dCanvas
android_webview/lib/main/aw_main_delegate.cc:70: 
cl->AppendSwitch(switches::kDisableAccelerated2dCanvas);
chrome/browser/about_flags.cc:441:   
SINGLE_VALUE_TYPE(switches::kDisableAccelerated2dCanvas)
chrome/browser/chromeos/login/chrome_restart_request.cc:70:     
::switches::kDisableAccelerated2dCanvas,
chrome/test/gpu/gpu_feature_browsertest.cc:422:   
command_line->AppendSwitch(switches::kDisableAccelerated2dCanvas);
chrome/test/perf/frame_rate/frame_rate_tests.cc:112:     
launch_arguments_.AppendSwitch(switches::kDisableAccelerated2dCanvas);
chrome/test/perf/rendering/throughput_tests.cc:199:     
command_line->AppendSwitch(switches::kDisableAccelerated2dCanvas);
content/browser/gpu/compositor_util.cc:49:         
command_line.HasSwitch(switches::kDisableAccelerated2dCanvas) ||
content/browser/gpu/gpu_data_manager_impl_private.cc:159:     
command_line.HasSwitch(switches::kDisableAccelerated2dCanvas),
content/browser/gpu/gpu_data_manager_impl_private.cc:987:   
command_line->AppendSwitch(switches::kDisableAccelerated2dCanvas);
content/browser/renderer_host/render_view_host_impl.cc:407:     
!command_line.HasSwitch(switches::kDisableAccelerated2dCanvas);
content/public/common/content_switches.cc:77:const char
kDisableAccelerated2dCanvas[]    = "disable-accelerated-2d-canvas";
content/public/common/content_switches.h:35:CONTENT_EXPORT extern const char
kDisableAccelerated2dCanvas[];


I'll deal with the other flags in a follow-up.