Do not release capture when clicking to open select box

Do not release capture when clicking to open select box on Linux Aura

BUG=414224, 414995
TEST=RenderWidgetHostViewAuraTest.PopupRetainsCaptureAfterMouseRelease

Committed: https://crrev.com/446f584e7f34ef00cf32f4cb17515334b3643aff
Cr-Commit-Position: refs/heads/master@{#295472}

[pkotwicz, 2014-09-16 01:26:45]

Patchset #1 (id:1) has been deleted

[pkotwicz, 2014-09-16 01:31:41]

Patchset #1 (id:20001) has been deleted

[pkotwicz, 2014-09-16 01:34:02]

Patchset #1 (id:40001) has been deleted

[pkotwicz, 2014-09-16 01:42:10]

pkotwicz@chromium.org changed reviewers:
+ oshima@chromium.org

[pkotwicz, 2014-09-16 01:54:20]

Oshima, PTAL

The select box menu should close when the window moves. I have filed a CrOS bug
which occurs because of this. crbug.com/414550

[oshima, 2014-09-16 16:17:24]

I think you should ask owner to review.

https://codereview.chromium.org/574583002/diff/60001/content/browser/renderer...
File content/browser/renderer_host/render_widget_host_view_aura.cc (right):

https://codereview.chromium.org/574583002/diff/60001/content/browser/renderer...
content/browser/renderer_host/render_widget_host_view_aura.cc:1871:
window_->ReleaseCapture();
who is closing the popup in this case?

[pkotwicz, 2014-09-17 02:27:24]

ben@ can you please take a look?

We added mouse capture for the sake of crbug.com/324364
We also need mouse capture on desktop Linux for proper behavior with focus
follows mouse.

[pkotwicz, 2014-09-17 02:27:40]

pkotwicz@chromium.org changed reviewers:
+ ben@chromium.org

[pkotwicz, 2014-09-17 02:27:58]

ben@ can you please take a look?

We added mouse capture for the sake of crbug.com/324364
We also need mouse capture on desktop Linux for proper behavior with focus
follows mouse.

https://codereview.chromium.org/574583002/diff/60001/content/browser/renderer...
File content/browser/renderer_host/render_widget_host_view_aura.cc (right):

https://codereview.chromium.org/574583002/diff/60001/content/browser/renderer...
content/browser/renderer_host/render_widget_host_view_aura.cc:1871:
window_->ReleaseCapture();
The popup is closed when
- The user clicks somewhere other the select box
RenderWidgetHostViewAura::ApplyEventFilterForPopupExit()
- The user selects an item in the select box
PopupListBox::handleMouseReleaseEvent()
- The web contents lose focus (e.g. Alt+Tab) WebViewImpl::setFocus()

Mouse capture is released when the popup is closed

[oshima, 2014-09-17 18:15:16]

lgtm

[Ben Goodger (Google), 2014-09-17 21:47:44]

lgtm

[pkotwicz, 2014-09-18 13:07:40]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2014-09-18 13:08:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/574583002/60001

[commit-bot: I haz the power, 2014-09-18 15:54:52]

Committed patchset #1 (id:60001) as b071562ca02e4d3c9da204bf4960d5ca24a0a0b9

[commit-bot: I haz the power, 2014-09-18 15:55:48]

Patchset 1 (id:??) landed as
https://crrev.com/446f584e7f34ef00cf32f4cb17515334b3643aff
Cr-Commit-Position: refs/heads/master@{#295472}