pkg/analysis_server/tool/spec/spec_input.html - Issue 574573002: Add SourceFileEdit.time field.

Side by Side Diff: pkg/analysis_server/tool/spec/spec_input.html

Issue 574573002: Add SourceFileEdit.time field. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 <html>	1 <html>

2 <head>	2 <head>

3 <meta charset="UTF-8"/>	3 <meta charset="UTF-8"/>

4 <title>Analysis Server API Specification</title>	4 <title>Analysis Server API Specification</title>

5 </head>	5 </head>

6 <body>	6 <body>

7 <h1>Analysis Server API Specification</h1>	7 <h1>Analysis Server API Specification</h1>

8 <h1 style="color:#999999">WORKING DRAFT - Version <version>0.3</version></h1 >	8 <h1 style="color:#999999">WORKING DRAFT - Version <version>0.3</version></h1 >

9 <p>	9 <p>

10 This document contains a specification of the API provided by	10 This document contains a specification of the API provided by

(...skipping 2862 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
2873 <p>	2873 <p>

2874 A description of a set of changes to a single file.	2874 A description of a set of changes to a single file.

2875 </p>	2875 </p>

2876 <object>	2876 <object>

2877 <field name="file">	2877 <field name="file">

2878 <ref>FilePath</ref>	2878 <ref>FilePath</ref>

2879 <p>	2879 <p>

2880 The file containing the code to be modified.	2880 The file containing the code to be modified.

2881 </p>	2881 </p>

2882 </field>	2882 </field>

	2883 <field name="time">
	Brian Wilkerson 2014/09/15 23:28:46 I don't think this does what we need it to. I thin I don't think this does what we need it to. I think the goal is to allow clients to know when a file has changed since the edit was created in order to know when it might not be safe to apply the edit. The problem is that the time stamps on files are not monotonically increasing. Certain operations can change the time stamp to be less than the previous value. The only safe way to test for "changed" is to use a not-equal comparison. Therefore, I think the time stamp included in the API needs to be the time stamp of the file at the time it was last analyzed, not the time at which the change was created. Also, this doesn't describe the convention we discussed of using a special value (like -1) to indicate a file that is expected to not exist. scheglov 2014/09/16 00:57:25 Agree. Show quoted text On 2014/09/15 23:28:46, Brian Wilkerson wrote: > I don't think this does what we need it to. I think the goal is to allow clients > to know when a file has changed since the edit was created in order to know when > it might not be safe to apply the edit. The problem is that the time stamps on > files are not monotonically increasing. Certain operations can change the time > stamp to be less than the previous value. The only safe way to test for > "changed" is to use a not-equal comparison. Therefore, I think the time stamp > included in the API needs to be the time stamp of the file at the time it was > last analyzed, not the time at which the change was created. > > Also, this doesn't describe the convention we discussed of using a special value > (like -1) to indicate a file that is expected to not exist. Agree.
	2884 <ref>int</ref>

	2885 <p>

	2886 The time in milliseconds since the "Unix epoch" when this change

	2887 was created. The client may use it to make sure that the file was

	2888 not changed since then, so it is safe to apply the change.

	2889 </p>

	2890 </field>

2883 <field name="edits">	2891 <field name="edits">

2884 <list><ref>SourceEdit</ref></list>	2892 <list><ref>SourceEdit</ref></list>

2885 <p>	2893 <p>

2886 A list of the edits used to effect the change.	2894 A list of the edits used to effect the change.

2887 </p>	2895 </p>

2888 </field>	2896 </field>

2889 </object>	2897 </object>

2890 </type>	2898 </type>

2891 <type name="TypeHierarchyItem">	2899 <type name="TypeHierarchyItem">

2892 <p>	2900 <p>

(...skipping 393 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
3286 <h2>Errors</h2>	3294 <h2>Errors</h2>

3287 <p>	3295 <p>

3288 This section contains a list of all of the errors that are	3296 This section contains a list of all of the errors that are

3289 produced by the server and the data that is returned with each.	3297 produced by the server and the data that is returned with each.

3290 </p>	3298 </p>

3291 <p>	3299 <p>

3292 TBD	3300 TBD

3293 </p>	3301 </p>

3294 </body>	3302 </body>

3295 </html>	3303 </html>

OLD	NEW

« no previous file with comments | « pkg/analysis_server/tool/spec/codegen_dart_protocol.dart ('k') | no next file » | no next file with comments »