Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Issue 574543002: Always disable the scissor test before BlitFrameBuffer (Closed)

Created:
6 years, 3 months ago by derekf
Modified:
6 years, 3 months ago
Reviewers:
hcm, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Always disable the scissor test before BlitFrameBuffer It seems most (all?) implementations of BlitFrameBuffer actually obey the scissor test, so just always disable the scissor before calling BlitFrameBuffer. Original Author: Henry Song <henrysong@samsung.com>; Committed: https://skia.googlesource.com/skia/+/8c8f71ac07f0611d2c3ec53551c7e0f6a1cc4789

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -12 lines) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/gl/GrGpuGL.cpp View 2 chunks +10 lines, -12 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
derekf
6 years, 3 months ago (2014-09-15 20:48:08 UTC) #2
bsalomon
Heather, is the authors stuff for this OK? Otherwise looks good.
6 years, 3 months ago (2014-09-15 20:58:09 UTC) #4
hcm
On 2014/09/15 20:58:09, bsalomon wrote: > Heather, is the authors stuff for this OK? Otherwise ...
6 years, 3 months ago (2014-09-16 03:17:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/574543002/1
6 years, 3 months ago (2014-09-16 13:18:17 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-16 13:25:01 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 8c8f71ac07f0611d2c3ec53551c7e0f6a1cc4789

Powered by Google App Engine
This is Rietveld 408576698