Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 574523002: Disable most MathML attributes (Closed)

Created:
6 years, 3 months ago by rwlbuis
Modified:
6 years, 3 months ago
Reviewers:
eseidel
CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Disable most MathML attributes The HTML parser only needs the encoding attribute to parse MathML content, so do not generate the other MathML attribute strings to save a bit in binary size and startup time. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182055

Patch Set 1 #

Patch Set 2 : Fix test results #

Patch Set 3 : Keep definitionURL #

Patch Set 4 : Patch for landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -20 lines) Patch
M Source/core/html/parser/MathMLAttributeNames.in View 1 2 3 1 chunk +0 lines, -20 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
rwlbuis
PTAL
6 years, 3 months ago (2014-09-15 21:26:58 UTC) #2
eseidel
The parser changes are that we're no longer re-writing definitionURL to the proper case? Is ...
6 years, 3 months ago (2014-09-15 22:14:39 UTC) #3
rwlbuis
On 2014/09/15 22:14:39, eseidel wrote: > The parser changes are that we're no longer re-writing ...
6 years, 3 months ago (2014-09-15 22:39:08 UTC) #4
eseidel
I would just delete them all instead of commenting them out. With the way the ...
6 years, 3 months ago (2014-09-16 06:17:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/574523002/60001
6 years, 3 months ago (2014-09-16 14:01:25 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-16 15:08:02 UTC) #8
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as 182055

Powered by Google App Engine
This is Rietveld 408576698