Issue 574493004: MIPS64: Removing ic.h from code-stubs.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 574493004: MIPS64: Removing ic.h from code-stubs.h (Closed)

Created:
6 years, 3 months ago by akos.palfi.imgtec

Modified:
6 years, 3 months ago

Reviewers:
balazs.kilvady, dusmil.imgtec, danno, mvstanton, gergely.kis.imgtec, paul.l...

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

MIPS64: Removing ic.h from code-stubs.h Port r23977 (d0cba839) Original commit message: CodeStubs use state types defined in ic.h, but this has the unfortunate effect of spreading ic.h all over the place. Instead, define these shared state types in ic-public.h and allow ic.h to concern itself with internal state change of the ICs. More work could/should be done here, but this is a first step. BUG= R=paul.lind@imgtec.com Committed: https://code.google.com/p/v8/source/detail?r=23984

Patch Set 1 #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+29 lines, -22 lines)			Patch
M	src/ic/mips64/handler-compiler-mips64.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/ic/mips64/ic-compiler-mips64.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/mips64/code-stubs-mips64.cc	View	13 chunks	+20 lines, -16 lines	0 comments	Download
M	src/mips64/full-codegen-mips64.cc	View	3 chunks	+6 lines, -6 lines	0 comments	Download
M	src/mips64/lithium-codegen-mips64.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

akos.palfi.imgtec

6 years, 3 months ago (2014-09-16 17:59:53 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 23984 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages