Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(757)

Issue 574463003: Remove implicit conversions from scoped_refptr to T* in c/b/renderer_host/pepper (Closed)

Created:
6 years, 3 months ago by dcheng
Modified:
6 years, 3 months ago
Reviewers:
bbudge
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove implicit conversions from scoped_refptr to T* in c/b/renderer_host/pepper This patch was generated by running the rewrite_scoped_refptr clang tool on a ChromeOS build. BUG=110610 Committed: https://crrev.com/7cfbf94b2614b6ec3c775fcfc3c56ccc7dc9f97c Cr-Commit-Position: refs/heads/master@{#294889}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/renderer_host/pepper/pepper_platform_verification_message_filter.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
dcheng
Some background: Unfortunately, we can't make scoped_refptr testable until the conversion operator has been removed. ...
6 years, 3 months ago (2014-09-15 20:00:38 UTC) #2
bbudge
lgtm
6 years, 3 months ago (2014-09-15 20:08:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/574463003/1
6 years, 3 months ago (2014-09-15 20:12:18 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as ac74331c0116715ca14af2cc3c7a2f9fa064660f
6 years, 3 months ago (2014-09-15 21:12:37 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-15 21:14:32 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7cfbf94b2614b6ec3c775fcfc3c56ccc7dc9f97c
Cr-Commit-Position: refs/heads/master@{#294889}

Powered by Google App Engine
This is Rietveld 408576698